Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TimelineUIUtilsImpl = function() 9 WebInspector.TimelineUIUtilsImpl = function()
10 { 10 {
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 case WebInspector.TimelineModel.RecordType.FunctionCall: 334 case WebInspector.TimelineModel.RecordType.FunctionCall:
335 details = linkifyLocation(recordData["scriptId"], recordData["scriptName "], recordData["scriptLine"], 0); 335 details = linkifyLocation(recordData["scriptId"], recordData["scriptName "], recordData["scriptLine"], 0);
336 break; 336 break;
337 case WebInspector.TimelineModel.RecordType.FireAnimationFrame: 337 case WebInspector.TimelineModel.RecordType.FireAnimationFrame:
338 detailsText = recordData["id"]; 338 detailsText = recordData["id"];
339 break; 339 break;
340 case WebInspector.TimelineModel.RecordType.EventDispatch: 340 case WebInspector.TimelineModel.RecordType.EventDispatch:
341 detailsText = recordData ? recordData["type"] : null; 341 detailsText = recordData ? recordData["type"] : null;
342 break; 342 break;
343 case WebInspector.TimelineModel.RecordType.Paint: 343 case WebInspector.TimelineModel.RecordType.Paint:
344 var width = WebInspector.TimelineUIUtils._quadWidth(recordData.clip); 344 var width = WebInspector.TimelineUIUtils.quadWidth(recordData.clip);
345 var height = WebInspector.TimelineUIUtils._quadHeight(recordData.clip); 345 var height = WebInspector.TimelineUIUtils.quadHeight(recordData.clip);
346 if (width && height) 346 if (width && height)
347 detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height); 347 detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height);
348 break; 348 break;
349 case WebInspector.TimelineModel.RecordType.TimerInstall: 349 case WebInspector.TimelineModel.RecordType.TimerInstall:
350 case WebInspector.TimelineModel.RecordType.TimerRemove: 350 case WebInspector.TimelineModel.RecordType.TimerRemove:
351 details = linkifyTopCallFrame(); 351 details = linkifyTopCallFrame();
352 detailsText = recordData["timerId"]; 352 detailsText = recordData["timerId"];
353 break; 353 break;
354 case WebInspector.TimelineModel.RecordType.RequestAnimationFrame: 354 case WebInspector.TimelineModel.RecordType.RequestAnimationFrame:
355 case WebInspector.TimelineModel.RecordType.CancelAnimationFrame: 355 case WebInspector.TimelineModel.RecordType.CancelAnimationFrame:
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 contentHelper.appendTextRow(WebInspector.UIString("Encoded Data Length"), WebInspector.UIString("%d Bytes", recordData["encodedDataLength"])); 586 contentHelper.appendTextRow(WebInspector.UIString("Encoded Data Length"), WebInspector.UIString("%d Bytes", recordData["encodedDataLength"]));
587 break; 587 break;
588 case recordTypes.EvaluateScript: 588 case recordTypes.EvaluateScript:
589 var url = recordData["url"]; 589 var url = recordData["url"];
590 if (url) 590 if (url)
591 contentHelper.appendLocationRow(WebInspector.UIString("Script"), url, recordData["lineNumber"]); 591 contentHelper.appendLocationRow(WebInspector.UIString("Script"), url, recordData["lineNumber"]);
592 break; 592 break;
593 case recordTypes.Paint: 593 case recordTypes.Paint:
594 var clip = recordData["clip"]; 594 var clip = recordData["clip"];
595 contentHelper.appendTextRow(WebInspector.UIString("Location"), WebIn spector.UIString("(%d, %d)", clip[0], clip[1])); 595 contentHelper.appendTextRow(WebInspector.UIString("Location"), WebIn spector.UIString("(%d, %d)", clip[0], clip[1]));
596 var clipWidth = WebInspector.TimelineUIUtils._quadWidth(clip); 596 var clipWidth = WebInspector.TimelineUIUtils.quadWidth(clip);
597 var clipHeight = WebInspector.TimelineUIUtils._quadHeight(clip); 597 var clipHeight = WebInspector.TimelineUIUtils.quadHeight(clip);
598 contentHelper.appendTextRow(WebInspector.UIString("Dimensions"), Web Inspector.UIString("%d × %d", clipWidth, clipHeight)); 598 contentHelper.appendTextRow(WebInspector.UIString("Dimensions"), Web Inspector.UIString("%d × %d", clipWidth, clipHeight));
599 // Fall-through intended. 599 // Fall-through intended.
600 600
601 case recordTypes.PaintSetup: 601 case recordTypes.PaintSetup:
602 case recordTypes.Rasterize: 602 case recordTypes.Rasterize:
603 case recordTypes.ScrollLayer: 603 case recordTypes.ScrollLayer:
604 relatedNodeLabel = WebInspector.UIString("Layer root"); 604 relatedNodeLabel = WebInspector.UIString("Layer root");
605 break; 605 break;
606 case recordTypes.DecodeImage: 606 case recordTypes.DecodeImage:
607 case recordTypes.ResizeImage: 607 case recordTypes.ResizeImage:
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 else if (recordType === recordTypes.TimeStamp) 695 else if (recordType === recordTypes.TimeStamp)
696 eventDivider.className += " resources-orange-divider"; 696 eventDivider.className += " resources-orange-divider";
697 else if (recordType === recordTypes.BeginFrame) 697 else if (recordType === recordTypes.BeginFrame)
698 eventDivider.className += " timeline-frame-divider"; 698 eventDivider.className += " timeline-frame-divider";
699 699
700 if (title) 700 if (title)
701 eventDivider.title = title; 701 eventDivider.title = title;
702 702
703 return eventDivider; 703 return eventDivider;
704 } 704 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698