Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 return selector + " { background-image: linear-gradient(" + 355 return selector + " { background-image: linear-gradient(" +
356 category.fillColorStop0 + ", " + category.fillColorStop1 + " 25%, " + cat egory.fillColorStop1 + " 25%, " + category.fillColorStop1 + ");" + 356 category.fillColorStop0 + ", " + category.fillColorStop1 + " 25%, " + cat egory.fillColorStop1 + " 25%, " + category.fillColorStop1 + ");" +
357 " border-color: " + category.borderColor + 357 " border-color: " + category.borderColor +
358 "}"; 358 "}";
359 } 359 }
360 360
361 /** 361 /**
362 * @param {!Array.<number>} quad 362 * @param {!Array.<number>} quad
363 * @return {number} 363 * @return {number}
364 */ 364 */
365 WebInspector.TimelineUIUtils._quadWidth = function(quad) 365 WebInspector.TimelineUIUtils.quadWidth = function(quad)
366 { 366 {
367 return Math.round(Math.sqrt(Math.pow(quad[0] - quad[2], 2) + Math.pow(quad[1 ] - quad[3], 2))); 367 return Math.round(Math.sqrt(Math.pow(quad[0] - quad[2], 2) + Math.pow(quad[1 ] - quad[3], 2)));
368 } 368 }
369 369
370 /** 370 /**
371 * @param {!Array.<number>} quad 371 * @param {!Array.<number>} quad
372 * @return {number} 372 * @return {number}
373 */ 373 */
374 WebInspector.TimelineUIUtils._quadHeight = function(quad) 374 WebInspector.TimelineUIUtils.quadHeight = function(quad)
375 { 375 {
376 return Math.round(Math.sqrt(Math.pow(quad[0] - quad[6], 2) + Math.pow(quad[1 ] - quad[7], 2))); 376 return Math.round(Math.sqrt(Math.pow(quad[0] - quad[6], 2) + Math.pow(quad[1 ] - quad[7], 2)));
377 } 377 }
378 378
379 /** 379 /**
380 * @constructor 380 * @constructor
381 * @extends {WebInspector.Object} 381 * @extends {WebInspector.Object}
382 * @param {string} name 382 * @param {string} name
383 * @param {string} title 383 * @param {string} title
384 * @param {number} overviewStripGroupIndex 384 * @param {number} overviewStripGroupIndex
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 for (var i = 0; i < stackTrace.length; ++i) { 562 for (var i = 0; i < stackTrace.length; ++i) {
563 var stackFrame = stackTrace[i]; 563 var stackFrame = stackTrace[i];
564 var row = stackTraceElement.createChild("div"); 564 var row = stackTraceElement.createChild("div");
565 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)")); 565 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)"));
566 row.createTextChild(" @ "); 566 row.createTextChild(" @ ");
567 var urlElement = this._linkifier.linkifyLocation(this._target, stack Frame.url, stackFrame.lineNumber - 1); 567 var urlElement = this._linkifier.linkifyLocation(this._target, stack Frame.url, stackFrame.lineNumber - 1);
568 row.appendChild(urlElement); 568 row.appendChild(urlElement);
569 } 569 }
570 } 570 }
571 } 571 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineTracingView.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698