Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 351903003: DevTools: Avoid private member access in non-profiler code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 { 838 {
839 this._delegate.requestWindowTimes(windowStartTime, windowEndTime); 839 this._delegate.requestWindowTimes(windowStartTime, windowEndTime);
840 }, 840 },
841 841
842 /** 842 /**
843 * @param {?RegExp} textFilter 843 * @param {?RegExp} textFilter
844 */ 844 */
845 refreshRecords: function(textFilter) 845 refreshRecords: function(textFilter)
846 { 846 {
847 this._dataProvider.reset(); 847 this._dataProvider.reset();
848 this._mainView._scheduleUpdate(); 848 this._mainView.scheduleUpdate();
849 }, 849 },
850 850
851 wasShown: function() 851 wasShown: function()
852 { 852 {
853 this._mainView._scheduleUpdate(); 853 this._mainView.scheduleUpdate();
854 }, 854 },
855 855
856 856
857 /** 857 /**
858 * @return {!WebInspector.View} 858 * @return {!WebInspector.View}
859 */ 859 */
860 view: function() 860 view: function()
861 { 861 {
862 return this; 862 return this;
863 }, 863 },
(...skipping 17 matching lines...) Expand all
881 */ 881 */
882 addRecord: function(record) 882 addRecord: function(record)
883 { 883 {
884 this._dataProvider.reset(); 884 this._dataProvider.reset();
885 if (this._automaticallySizeWindow) { 885 if (this._automaticallySizeWindow) {
886 var minimumRecordTime = this._model.minimumRecordTime(); 886 var minimumRecordTime = this._model.minimumRecordTime();
887 if (record.startTime() > (minimumRecordTime + 1000)) { 887 if (record.startTime() > (minimumRecordTime + 1000)) {
888 this._automaticallySizeWindow = false; 888 this._automaticallySizeWindow = false;
889 this._delegate.requestWindowTimes(minimumRecordTime, minimumReco rdTime + 1000); 889 this._delegate.requestWindowTimes(minimumRecordTime, minimumReco rdTime + 1000);
890 } 890 }
891 this._mainView._scheduleUpdate(); 891 this._mainView.scheduleUpdate();
892 } else { 892 } else {
893 if (!this._pendingUpdateTimer) 893 if (!this._pendingUpdateTimer)
894 this._pendingUpdateTimer = window.setTimeout(this._updateOnAddRe cord.bind(this), 300); 894 this._pendingUpdateTimer = window.setTimeout(this._updateOnAddRe cord.bind(this), 300);
895 } 895 }
896 }, 896 },
897 897
898 _updateOnAddRecord: function() 898 _updateOnAddRecord: function()
899 { 899 {
900 delete this._pendingUpdateTimer; 900 delete this._pendingUpdateTimer;
901 this._mainView._scheduleUpdate(); 901 this._mainView.scheduleUpdate();
902 }, 902 },
903 903
904 /** 904 /**
905 * @param {number} startTime 905 * @param {number} startTime
906 * @param {number} endTime 906 * @param {number} endTime
907 */ 907 */
908 setWindowTimes: function(startTime, endTime) 908 setWindowTimes: function(startTime, endTime)
909 { 909 {
910 this._mainView.setWindowTimes(startTime, endTime); 910 this._mainView.setWindowTimes(startTime, endTime);
911 this._delegate.select(null); 911 this._delegate.select(null);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
971 * @param {number} entryIndex 971 * @param {number} entryIndex
972 * @return {?WebInspector.TimelineSelection} 972 * @return {?WebInspector.TimelineSelection}
973 */ 973 */
974 createSelection: function(entryIndex) { }, 974 createSelection: function(entryIndex) { },
975 /** 975 /**
976 * @param {?WebInspector.TimelineSelection} selection 976 * @param {?WebInspector.TimelineSelection} selection
977 * @return {number} 977 * @return {number}
978 */ 978 */
979 entryIndexForSelection: function(selection) { } 979 entryIndexForSelection: function(selection) { }
980 } 980 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/Layers3DView.js ('k') | Source/devtools/front_end/timeline/TimelineTracingView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698