Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 351873003: Unflaky test inspector/timeline/timeline-network-received-data.html (Closed)

Created:
6 years, 5 months ago by loislo
Modified:
6 years, 5 months ago
Reviewers:
caseq, alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Unflaky test inspector/timeline/timeline-network-received-data.html It was a race between the event arrived into timeline and the script that was evaluated in the page. BUG=316150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177131

Patch Set 1 #

Patch Set 2 : another test was adjusted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-received-data.html View 1 2 chunks +14 lines, -6 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-received-data-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
6 years, 5 months ago (2014-06-27 16:22:16 UTC) #1
alph
lgtm
6 years, 5 months ago (2014-06-27 16:30:00 UTC) #2
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 5 months ago (2014-06-27 16:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/351873003/20001
6 years, 5 months ago (2014-06-27 16:33:38 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 20:39:12 UTC) #5
Message was sent while issue was closed.
Change committed as 177131

Powered by Google App Engine
This is Rietveld 408576698