Added SERVER_UNAUTHORIZED download interrupt reason.

Added SERVER_UNAUTHORIZED download interrupt reason.

chrome/app/generated_resources.grd: added messages for
DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED
content/browser/download: handling of
DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED

BUG=386146
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285359

[Lukasz Jagielski, 2014-06-24 11:20:19]

Hi,
PTAL at my proposition of change for situations, is which we receive http
error 401 unauthorized when downloading a file. Currently there's a
'unknown error' message, which doesn't explain what happened well.
Regards,
Łukasz

[jochen (gone - plz use gerrit), 2014-06-24 14:03:38]

lgtm

[asanka, 2014-06-24 14:53:12]

Have you run through unit_tests and browser_tests? I believe unit_tests wouldn't
compile without updating the tests for the new interrupt reason, and the new
value also needs to be added to downloads.idl for the extensions API.

[asanka, 2014-06-24 14:54:00]

Thanks for doing this, by the way :)

[Lukasz Jagielski, 2014-06-25 13:25:56]

Sorry, I haven't run run through tests then.
Regards,
Łukasz

[Lukasz Jagielski, 2014-07-02 15:52:07]

Hi,
PTAL at new changes, I added code for handling downloads interrupted by
server's ssl certificate problem.
Regards,
Łukasz

[asanka, 2014-07-11 18:13:53]

https://codereview.chromium.org/351863002/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/351863002/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:1771: +        Not authorized
"Needs authorization"

https://codereview.chromium.org/351863002/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:1778: +               desc="Server cert
problem.">
Nit: spell out certificate.

https://codereview.chromium.org/351863002/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:1779: +        Server certificate problem
"Bad certificate"

https://codereview.chromium.org/351863002/diff/40001/content/browser/download...
File content/browser/download/download_resource_handler.cc (right):

https://codereview.chromium.org/351863002/diff/40001/content/browser/download...
content/browser/download/download_resource_handler.cc:112:
&ssl_signed_certificate_timestamp_ids))
Nit: Formatting seems off. "git cl format" ?

Note that 'git cl format' might try to reformat tests etc. in not very desirable
ways. Just pick the parts that look sensible until these problems are resolved.

https://codereview.chromium.org/351863002/diff/40001/content/browser/download...
content/browser/download/download_resource_handler.cc:403: if
(IsSSLCertificateError(security_info))
if (net::IsCertStatusError(request()->ssl_info().cert_status))

[Lukasz Jagielski, 2014-07-17 13:49:43]

Hi,
Please take a look at my fixups.
Regards,
Łukasz

[asanka, 2014-07-17 15:06:24]

LGTM.  Thanks!

[Lukasz Jagielski, 2014-07-18 06:25:41]

The CQ bit was checked by ljagielski@opera.com

[commit-bot: I haz the power, 2014-07-18 06:27:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ljagielski@opera.com/351863002/60001

[commit-bot: I haz the power, 2014-07-18 10:03:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-18 11:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 11:21:16]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Lukasz Jagielski, 2014-07-18 11:43:11]

The CQ bit was checked by ljagielski@opera.com

[commit-bot: I haz the power, 2014-07-18 11:43:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ljagielski@opera.com/351863002/80001

[commit-bot: I haz the power, 2014-07-18 16:01:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-18 16:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 16:07:19]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Lukasz Jagielski, 2014-07-21 13:20:07]

Hi,
Sorry for my oversights with tests, please take a look at hopefully
last fixes.
Regards,
Łukasz

[Lukasz Jagielski, 2014-07-24 14:14:03]

The CQ bit was checked by ljagielski@opera.com

[commit-bot: I haz the power, 2014-07-24 14:14:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ljagielski@opera.com/351863002/100001

[commit-bot: I haz the power, 2014-07-24 16:07:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-24 20:35:49]

Change committed as 285359