src/scopeinfo.cc - Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopeinfo.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/scopeinfo.cc

diff --git a/src/scopeinfo.cc b/src/scopeinfo.cc

index d84c5bf0057b16779cfda42d2da65bcc23f745b4..db888fdb2bb464fa4a3c5ce337b746aa17eb9b68 100644

--- a/src/scopeinfo.cc

+++ b/src/scopeinfo.cc

@@ -368,13 +368,11 @@ bool ScopeInfo::CopyContextLocalsToScopeObject(Handle<ScopeInfo> scope_info,

int context_index = Context::MIN_CONTEXT_SLOTS + i;

RETURN_ON_EXCEPTION_VALUE(

isolate,

- Runtime::SetObjectProperty(

- isolate,

+ Runtime::DefineObjectProperty(

scope_object,

Handle<String>(String::cast(scope_info->get(i + start))),

Handle<Object>(context->get(context_index), isolate),

- ::NONE,

- SLOPPY),

+ ::NONE),

false);

}

return true;

« no previous file with comments | « src/runtime.cc ('k') | src/string.js » ('j') | no next file with comments »