src/string.js - Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index 07cdcc043f02c1eeaca0cca4fb2698a43881d544..47b2be8b67120d24a21e9941a0ad4469d2440908 100644

--- a/src/string.js

+++ b/src/string.js

@@ -915,7 +915,7 @@ function SetUpString() {

%FunctionSetPrototype($String, new $String());

// Set up the constructor property on the String prototype object.

- %SetProperty($String.prototype, "constructor", $String, DONT_ENUM);

+ %DefineProperty($String.prototype, "constructor", $String, DONT_ENUM);

// Set up the non-enumerable functions on the String object.

InstallFunctions($String, DONT_ENUM, $Array(

« src/runtime.cc ('K') | « src/scopeinfo.cc ('k') | src/symbol.js » ('j') | no next file with comments »