Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

src/runtime.h

Index: src/runtime.h
diff --git a/src/runtime.h b/src/runtime.h
index 494033bceca75bfebd9635852807e11ee84614d8..255b19061bafd5365f495d66ef196b10af1a0e3c 100644
--- a/src/runtime.h
+++ b/src/runtime.h
@@ -206,7 +206,7 @@ namespace internal {
   F(GetTemplateField, 2, 1) \
   F(DisableAccessChecks, 1, 1) \
   F(EnableAccessChecks, 1, 1) \
-  F(SetAccessorProperty, 5, 1) \
+  F(DefineAccessorProperty, 5, 1) \

[rossberg, 2014/06/27 09:47:30]

Nit: move this down to the other Define functions

[Toon Verwaest, 2014/06/27 13:16:22]

Done.

   \
   /* Dates */ \
   F(DateCurrentTime, 0, 1) \
@@ -224,7 +224,8 @@ namespace internal {
   F(GlobalReceiver, 1, 1) \
   F(IsAttachedGlobal, 1, 1) \
   \
-  F(SetProperty, -1 /* 4 or 5 */, 1) \
+  F(DefineProperty, 4, 1) \

[rossberg, 2014/06/27 09:47:30]

How about naming this DefineDataProperty, for symmetry?

+  F(SetProperty, 4, 1) \
   F(DefineOrRedefineDataProperty, 4, 1) \
   F(DefineOrRedefineAccessorProperty, 5, 1) \
   F(IgnoreAttributesAndSetProperty, -1 /* 3 or 4 */, 1) \
@@ -805,21 +806,23 @@ class Runtime : public AllStatic {
       Handle<Object> object,
       uint32_t index);
 
+  // Do not use SetObjectProperty to configure a property with specific
+  // attributes. The argument will be removed once the API is adapted.
   MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty(
       Isolate* isolate,
       Handle<Object> object,
       Handle<Object> key,
       Handle<Object> value,
-      PropertyAttributes attr,
-      StrictMode strict_mode);
+      StrictMode strict_mode,
+      PropertyAttributes attributes = NONE);
 
   MUST_USE_RESULT static MaybeHandle<Object> ForceSetObjectProperty(

[rossberg, 2014/06/27 09:47:30]

It might make sense to also rename this to DefineObjectProperty.

[Toon Verwaest, 2014/06/27 13:16:22]

Done.

       Handle<JSObject> object,
       Handle<Object> key,
       Handle<Object> value,
       PropertyAttributes attr,
-      JSReceiver::StoreFromKeyed store_from_keyed
-        = JSReceiver::MAY_BE_STORE_FROM_KEYED);
+      JSReceiver::StoreFromKeyed store_from_keyed =
+          JSReceiver::MAY_BE_STORE_FROM_KEYED);
 
   MUST_USE_RESULT static MaybeHandle<Object> DeleteObjectProperty(
       Isolate* isolate,