Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/collection-iterator.js

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/collection-iterator.js
diff --git a/src/collection-iterator.js b/src/collection-iterator.js
index 2436a931e28bc4acde80f5c4a8143cc0bff5b8f3..79490f51de5c53bd878246e86811b4e29e669eea 100644
--- a/src/collection-iterator.js
+++ b/src/collection-iterator.js
@@ -59,7 +59,7 @@ function SetUpSetIterator() {
));
%FunctionSetName(SetIteratorSymbolIterator, '[Symbol.iterator]');
- %SetProperty(SetIterator.prototype, symbolIterator,
+ %DefineProperty(SetIterator.prototype, symbolIterator,
SetIteratorSymbolIterator, DONT_ENUM);
}
@@ -74,7 +74,7 @@ function ExtendSetPrototype() {
'values', SetValues
));
- %SetProperty($Set.prototype, symbolIterator, SetValues,
+ %DefineProperty($Set.prototype, symbolIterator, SetValues,
DONT_ENUM);
}
@@ -139,7 +139,7 @@ function SetUpMapIterator() {
));
%FunctionSetName(MapIteratorSymbolIterator, '[Symbol.iterator]');
- %SetProperty(MapIterator.prototype, symbolIterator,
+ %DefineProperty(MapIterator.prototype, symbolIterator,
MapIteratorSymbolIterator, DONT_ENUM);
}
@@ -155,7 +155,7 @@ function ExtendMapPrototype() {
'values', MapValues
));
- %SetProperty($Map.prototype, symbolIterator, MapEntries,
+ %DefineProperty($Map.prototype, symbolIterator, MapEntries,
DONT_ENUM);
}

Powered by Google App Engine
This is Rietveld 408576698