Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/cctest/test-compiler.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 isolate, isolate->global_object(), name).ToHandleChecked(); 42 isolate, isolate->global_object(), name).ToHandleChecked();
43 } 43 }
44 44
45 45
46 static void SetGlobalProperty(const char* name, Object* value) { 46 static void SetGlobalProperty(const char* name, Object* value) {
47 Isolate* isolate = CcTest::i_isolate(); 47 Isolate* isolate = CcTest::i_isolate();
48 Handle<Object> object(value, isolate); 48 Handle<Object> object(value, isolate);
49 Handle<String> internalized_name = 49 Handle<String> internalized_name =
50 isolate->factory()->InternalizeUtf8String(name); 50 isolate->factory()->InternalizeUtf8String(name);
51 Handle<JSObject> global(isolate->context()->global_object()); 51 Handle<JSObject> global(isolate->context()->global_object());
52 Runtime::SetObjectProperty(isolate, global, internalized_name, object, NONE, 52 Runtime::SetObjectProperty(isolate, global, internalized_name, object,
53 SLOPPY).Check(); 53 SLOPPY).Check();
54 } 54 }
55 55
56 56
57 static Handle<JSFunction> Compile(const char* source) { 57 static Handle<JSFunction> Compile(const char* source) {
58 Isolate* isolate = CcTest::i_isolate(); 58 Isolate* isolate = CcTest::i_isolate();
59 Handle<String> source_code = isolate->factory()->NewStringFromUtf8( 59 Handle<String> source_code = isolate->factory()->NewStringFromUtf8(
60 CStrVector(source)).ToHandleChecked(); 60 CStrVector(source)).ToHandleChecked();
61 Handle<SharedFunctionInfo> shared_function = 61 Handle<SharedFunctionInfo> shared_function =
62 Compiler::CompileScript(source_code, 62 Compiler::CompileScript(source_code,
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 CompileRun("function f() { a = 12345678 }; f();"); 443 CompileRun("function f() { a = 12345678 }; f();");
444 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f")); 444 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f"));
445 CompileRun("function f(x) { a = 12345678 + x}; f(1);"); 445 CompileRun("function f(x) { a = 12345678 + x}; f(1);");
446 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f")); 446 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f"));
447 CompileRun("function f(x) { var arguments = 1; x += 12345678}; f(1);"); 447 CompileRun("function f(x) { var arguments = 1; x += 12345678}; f(1);");
448 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f")); 448 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f"));
449 CompileRun("function f(x) { var arguments = 1; x = 12345678}; f(1);"); 449 CompileRun("function f(x) { var arguments = 1; x = 12345678}; f(1);");
450 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f")); 450 CheckCodeForUnsafeLiteral(GetJSFunction(context->Global(), "f"));
451 } 451 }
452 #endif 452 #endif
OLDNEW
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698