Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/apinatives.js ('k') | src/arm/ic-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1680 matching lines...) Expand 10 before | Expand all | Expand 10 after
1691 break; 1691 break;
1692 } 1692 }
1693 // Duplicate receiver on stack. 1693 // Duplicate receiver on stack.
1694 __ ldr(r0, MemOperand(sp)); 1694 __ ldr(r0, MemOperand(sp));
1695 __ push(r0); 1695 __ push(r0);
1696 VisitForStackValue(key); 1696 VisitForStackValue(key);
1697 VisitForStackValue(value); 1697 VisitForStackValue(value);
1698 if (property->emit_store()) { 1698 if (property->emit_store()) {
1699 __ mov(r0, Operand(Smi::FromInt(NONE))); // PropertyAttributes 1699 __ mov(r0, Operand(Smi::FromInt(NONE))); // PropertyAttributes
1700 __ push(r0); 1700 __ push(r0);
1701 __ CallRuntime(Runtime::kSetProperty, 4); 1701 __ CallRuntime(Runtime::kAddProperty, 4);
1702 } else { 1702 } else {
1703 __ Drop(3); 1703 __ Drop(3);
1704 } 1704 }
1705 break; 1705 break;
1706 case ObjectLiteral::Property::PROTOTYPE: 1706 case ObjectLiteral::Property::PROTOTYPE:
1707 // Duplicate receiver on stack. 1707 // Duplicate receiver on stack.
1708 __ ldr(r0, MemOperand(sp)); 1708 __ ldr(r0, MemOperand(sp));
1709 __ push(r0); 1709 __ push(r0);
1710 VisitForStackValue(value); 1710 VisitForStackValue(value);
1711 if (property->emit_store()) { 1711 if (property->emit_store()) {
(...skipping 17 matching lines...) Expand all
1729 for (AccessorTable::Iterator it = accessor_table.begin(); 1729 for (AccessorTable::Iterator it = accessor_table.begin();
1730 it != accessor_table.end(); 1730 it != accessor_table.end();
1731 ++it) { 1731 ++it) {
1732 __ ldr(r0, MemOperand(sp)); // Duplicate receiver. 1732 __ ldr(r0, MemOperand(sp)); // Duplicate receiver.
1733 __ push(r0); 1733 __ push(r0);
1734 VisitForStackValue(it->first); 1734 VisitForStackValue(it->first);
1735 EmitAccessor(it->second->getter); 1735 EmitAccessor(it->second->getter);
1736 EmitAccessor(it->second->setter); 1736 EmitAccessor(it->second->setter);
1737 __ mov(r0, Operand(Smi::FromInt(NONE))); 1737 __ mov(r0, Operand(Smi::FromInt(NONE)));
1738 __ push(r0); 1738 __ push(r0);
1739 __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5); 1739 __ CallRuntime(Runtime::kDefineAccessorPropertyUnchecked, 5);
1740 } 1740 }
1741 1741
1742 if (expr->has_function()) { 1742 if (expr->has_function()) {
1743 ASSERT(result_saved); 1743 ASSERT(result_saved);
1744 __ ldr(r0, MemOperand(sp)); 1744 __ ldr(r0, MemOperand(sp));
1745 __ push(r0); 1745 __ push(r0);
1746 __ CallRuntime(Runtime::kToFastProperties, 1); 1746 __ CallRuntime(Runtime::kToFastProperties, 1);
1747 } 1747 }
1748 1748
1749 if (result_saved) { 1749 if (result_saved) {
(...skipping 3071 matching lines...) Expand 10 before | Expand all | Expand 10 after
4821 4821
4822 ASSERT(interrupt_address == 4822 ASSERT(interrupt_address ==
4823 isolate->builtins()->OsrAfterStackCheck()->entry()); 4823 isolate->builtins()->OsrAfterStackCheck()->entry());
4824 return OSR_AFTER_STACK_CHECK; 4824 return OSR_AFTER_STACK_CHECK;
4825 } 4825 }
4826 4826
4827 4827
4828 } } // namespace v8::internal 4828 } } // namespace v8::internal
4829 4829
4830 #endif // V8_TARGET_ARCH_ARM 4830 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/apinatives.js ('k') | src/arm/ic-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698