Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

src/runtime.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_RUNTIME_H_
 #define V8_RUNTIME_H_
 
 #include "src/allocation.h"
 #include "src/zone.h"
 
@@ skipping 188 matching lines @@
   F(GetAndClearOverflowedStackTrace, 1, 1) \
   F(GetV8Version, 0, 1) \
   \
   F(SetCode, 2, 1) \
   \
   F(CreateApiFunction, 2, 1) \
   F(IsTemplate, 1, 1) \
   F(GetTemplateField, 2, 1) \
   F(DisableAccessChecks, 1, 1) \
   F(EnableAccessChecks, 1, 1) \
-  F(SetAccessorProperty, 5, 1) \
+  F(DefineAccessorProperty, 5, 1) \

[rossberg, 2014/06/27 09:47:30]

Nit: move this down to the other Define functions

[Toon Verwaest, 2014/06/27 13:16:22]

Done.

   \
   /* Dates */ \
   F(DateCurrentTime, 0, 1) \
   F(DateParseString, 2, 1) \
   F(DateLocalTimezone, 1, 1) \
   F(DateToUTC, 1, 1) \
   F(DateMakeDay, 2, 1) \
   F(DateSetValue, 3, 1) \
   F(DateCacheVersion, 0, 1) \
   \
   /* Globals */ \
   F(CompileString, 2, 1) \
   \
   /* Eval */ \
   F(GlobalReceiver, 1, 1) \
   F(IsAttachedGlobal, 1, 1) \
   \
-  F(SetProperty, -1 /* 4 or 5 */, 1) \
+  F(DefineProperty, 4, 1) \

[rossberg, 2014/06/27 09:47:30]

How about naming this DefineDataProperty, for symmetry?

+  F(SetProperty, 4, 1) \
   F(DefineOrRedefineDataProperty, 4, 1) \
   F(DefineOrRedefineAccessorProperty, 5, 1) \
   F(IgnoreAttributesAndSetProperty, -1 /* 3 or 4 */, 1) \
   F(GetDataProperty, 2, 1) \
   F(SetHiddenProperty, 3, 1) \
   \
   /* Arrays */ \
   F(RemoveArrayHoles, 2, 1) \
   F(GetArrayKeys, 2, 1) \
   F(MoveArrayContents, 2, 1) \
@@ skipping 560 matching lines @@
   // TODO(1240886): Some of the following methods are *not* handle safe, but
   // accept handle arguments. This seems fragile.
 
   // Support getting the characters in a string using [] notation as
   // in Firefox/SpiderMonkey, Safari and Opera.
   MUST_USE_RESULT static MaybeHandle<Object> GetElementOrCharAt(
       Isolate* isolate,
       Handle<Object> object,
       uint32_t index);
 
+  // Do not use SetObjectProperty to configure a property with specific
+  // attributes. The argument will be removed once the API is adapted.
   MUST_USE_RESULT static MaybeHandle<Object> SetObjectProperty(
       Isolate* isolate,
       Handle<Object> object,
       Handle<Object> key,
       Handle<Object> value,
-      PropertyAttributes attr,
-      StrictMode strict_mode);
+      StrictMode strict_mode,
+      PropertyAttributes attributes = NONE);
 
   MUST_USE_RESULT static MaybeHandle<Object> ForceSetObjectProperty(

[rossberg, 2014/06/27 09:47:30]

It might make sense to also rename this to DefineObjectProperty.

[Toon Verwaest, 2014/06/27 13:16:22]

Done.

       Handle<JSObject> object,
       Handle<Object> key,
       Handle<Object> value,
       PropertyAttributes attr,
-      JSReceiver::StoreFromKeyed store_from_keyed
-        = JSReceiver::MAY_BE_STORE_FROM_KEYED);
+      JSReceiver::StoreFromKeyed store_from_keyed =
+          JSReceiver::MAY_BE_STORE_FROM_KEYED);
 
   MUST_USE_RESULT static MaybeHandle<Object> DeleteObjectProperty(
       Isolate* isolate,
       Handle<JSReceiver> object,
       Handle<Object> key,
       JSReceiver::DeleteMode mode);
 
   MUST_USE_RESULT static MaybeHandle<Object> HasObjectProperty(
       Isolate* isolate,
       Handle<JSReceiver> object,
@@ skipping 58 matching lines @@
 class AllocateDoubleAlignFlag:  public BitField<bool,            0, 1> {};
 class AllocateTargetSpace:      public BitField<AllocationSpace, 1, 3> {};
 
 class DeclareGlobalsEvalFlag:   public BitField<bool,       0, 1> {};
 class DeclareGlobalsNativeFlag: public BitField<bool,       1, 1> {};
 class DeclareGlobalsStrictMode: public BitField<StrictMode, 2, 1> {};
 
 } }  // namespace v8::internal
 
 #endif  // V8_RUNTIME_H_