Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

src/regexp.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file relies on the fact that the following declaration has been made
 // in runtime.js:
 // var $Object = global.Object;
 // var $Array = global.Array;
 
 var $RegExp = global.RegExp;
@@ skipping 363 matching lines @@
 // Used internally by replace regexp with function.
 // The array has the format of an "apply" argument for a replacement
 // function.
 var lastMatchInfoOverride = null;
 
 // -------------------------------------------------------------------
 
 function SetUpRegExp() {
   %CheckIsBootstrapping();
   %FunctionSetInstanceClassName($RegExp, 'RegExp');
-  %SetProperty($RegExp.prototype, 'constructor', $RegExp, DONT_ENUM);
+  %DefineProperty($RegExp.prototype, 'constructor', $RegExp, DONT_ENUM);
   %SetCode($RegExp, RegExpConstructor);
 
   InstallFunctions($RegExp.prototype, DONT_ENUM, $Array(
     "exec", RegExpExec,
     "test", RegExpTest,
     "toString", RegExpToString,
     "compile", RegExpCompileJS
   ));
 
   // The length of compile is 1 in SpiderMonkey.
   %FunctionSetLength($RegExp.prototype.compile, 1);
 
   // The properties input, $input, and $_ are aliases for each other.  When this
   // value is set the value it is set to is coerced to a string.
   // Getter and setter for the input.
   var RegExpGetInput = function() {
     var regExpInput = LAST_INPUT(lastMatchInfo);
     return IS_UNDEFINED(regExpInput) ? "" : regExpInput;
   };
   var RegExpSetInput = function(string) {
     LAST_INPUT(lastMatchInfo) = ToString(string);
   };
 
   %OptimizeObjectForAddingMultipleProperties($RegExp, 22);
   %DefineOrRedefineAccessorProperty($RegExp, 'input', RegExpGetInput,

[rossberg, 2014/06/27 09:47:30]

Can't these simply be %DefineAccessorProperty now?

[Toon Verwaest, 2014/06/27 13:16:22]

Done.

                                     RegExpSetInput, DONT_DELETE);
   %DefineOrRedefineAccessorProperty($RegExp, '$_', RegExpGetInput,
                                     RegExpSetInput, DONT_ENUM | DONT_DELETE);
   %DefineOrRedefineAccessorProperty($RegExp, '$input', RegExpGetInput,
                                     RegExpSetInput, DONT_ENUM | DONT_DELETE);
 
   // The properties multiline and $* are aliases for each other.  When this
   // value is set in SpiderMonkey, the value it is set to is coerced to a
   // boolean.  We mimic that behavior with a slight difference: in SpiderMonkey
   // the value of the expression 'RegExp.multiline = null' (for instance) is the
@@ skipping 37 matching lines @@
 
   for (var i = 1; i < 10; ++i) {
     %DefineOrRedefineAccessorProperty($RegExp, '$' + i,
                                       RegExpMakeCaptureGetter(i), NoOpSetter,
                                       DONT_DELETE);
   }
   %ToFastProperties($RegExp);
 }
 
 SetUpRegExp();