add path dump test

add path dump test

Add a unit test for SkPath::dump(). The unit test exposed a minor
bug (inconsistent CRs) and an unused parameter (title).

TBR=bsalomon
BUG=skia:1836
Committed: https://skia.googlesource.com/skia/+/66a5d8bf13fe98baae268db0211e9c25e5ece7fa

[caryclark, 2014-06-24 14:37:15]

Brian, please review.

[bsalomon, 2014-06-24 14:54:06]

https://codereview.chromium.org/351833003/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/351833003/diff/1/tests/PathTest.cpp#newcode3387
tests/PathTest.cpp:3387: "path.lineTo(1, 2);\n"
Sorry for screwing this up! Is it necessary for SkPath::dump() to always end
with two newlines? If it ends with one then the caller can always decide to
introduce a blank line. The current SkClipStack::dump() would prefer to not have
a blank line.

[caryclark, 2014-06-24 15:08:47]

https://codereview.chromium.org/351833003/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/351833003/diff/1/tests/PathTest.cpp#newcode3387
tests/PathTest.cpp:3387: "path.lineTo(1, 2);\n"
On 2014/06/24 14:54:06, bsalomon wrote:
> Sorry for screwing this up! Is it necessary for SkPath::dump() to always end
> with two newlines? If it ends with one then the caller can always decide to
> introduce a blank line. The current SkClipStack::dump() would prefer to not
have
> a blank line.

Done.

[bsalomon, 2014-06-24 15:11:52]

lgtm

[caryclark, 2014-06-24 15:12:31]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2014-06-24 15:12:59]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/caryclark@google.com/351833003/20001

[commit-bot: I haz the power, 2014-06-24 15:30:24]

Change committed as 66a5d8bf13fe98baae268db0211e9c25e5ece7fa