Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: pdf/pdf.gyp

Issue 351773005: Don't use a version script when linking libpdf.so (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pdf/libpdf.map ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'chromium_code': 1, 3 'chromium_code': 1,
4 'pdf_engine%': 0, # 0 PDFium 4 'pdf_engine%': 0, # 0 PDFium
5 }, 5 },
6 'target_defaults': { 6 'target_defaults': {
7 'cflags': [ 7 'cflags': [
8 '-fPIC', 8 '-fPIC',
9 ], 9 ],
10 }, 10 },
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 }], 111 }],
112 ['OS=="linux"', { 112 ['OS=="linux"', {
113 'configurations': { 113 'configurations': {
114 'Release_Base': { 114 'Release_Base': {
115 #'cflags': [ '-fno-weak',], # get rid of symbols that strip doesn 't remove. 115 #'cflags': [ '-fno-weak',], # get rid of symbols that strip doesn 't remove.
116 # Don't do this for now since official builder will take care of i t. That 116 # Don't do this for now since official builder will take care of i t. That
117 # way symbols can still be uploaded to the crash server. 117 # way symbols can still be uploaded to the crash server.
118 #'ldflags': [ '-s',], # strip local symbols from binary. 118 #'ldflags': [ '-s',], # strip local symbols from binary.
119 }, 119 },
120 }, 120 },
121 # Use a custom version script to prevent leaking the vendor name in
122 # visible symbols.
123 'ldflags': [
124 '-Wl,--version-script=<!(cd <(DEPTH) && pwd -P)/pdf/libpdf.map'
125 ],
126 }], 121 }],
127 ], 122 ],
128 }, 123 },
129 ], 124 ],
130 'conditions': [ 125 'conditions': [
131 # CrOS has a separate step to do this. 126 # CrOS has a separate step to do this.
132 ['OS=="linux" and chromeos==0', 127 ['OS=="linux" and chromeos==0',
133 { 'targets': [ 128 { 'targets': [
134 { 129 {
135 'target_name': 'pdf_linux_symbols', 130 'target_name': 'pdf_linux_symbols',
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 '--input_symbol', '<(PRODUCT_DIR)/pdf.dll.pdb', 191 '--input_symbol', '<(PRODUCT_DIR)/pdf.dll.pdb',
197 '--destination_dir', '<(dest_dir)', 192 '--destination_dir', '<(dest_dir)',
198 ], 193 ],
199 }, 194 },
200 ], 195 ],
201 }, 196 },
202 ], 197 ],
203 }], # OS=="win" and fastbuild==0 and target_arch=="ia32" and syzyasan==1 198 }], # OS=="win" and fastbuild==0 and target_arch=="ia32" and syzyasan==1
204 ], 199 ],
205 } 200 }
OLDNEW
« no previous file with comments | « pdf/libpdf.map ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698