Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/hydrogen.cc

Issue 35173005: Fix HObjectAccess for loads from migrating prototypes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-305309.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4741 matching lines...) Expand 10 before | Expand all | Expand 10 after
4752 } 4752 }
4753 4753
4754 return true; 4754 return true;
4755 } 4755 }
4756 4756
4757 4757
4758 bool HOptimizedGraphBuilder::PropertyAccessInfo::LookupInPrototypes() { 4758 bool HOptimizedGraphBuilder::PropertyAccessInfo::LookupInPrototypes() {
4759 Handle<Map> map = map_; 4759 Handle<Map> map = map_;
4760 while (map->prototype()->IsJSObject()) { 4760 while (map->prototype()->IsJSObject()) {
4761 holder_ = handle(JSObject::cast(map->prototype())); 4761 holder_ = handle(JSObject::cast(map->prototype()));
4762 if (holder_->map()->is_deprecated()) {
4763 JSObject::TryMigrateInstance(holder_);
4764 }
4762 map = Handle<Map>(holder_->map()); 4765 map = Handle<Map>(holder_->map());
4763 if (!CanInlinePropertyAccess(*map)) { 4766 if (!CanInlinePropertyAccess(*map)) {
4764 lookup_.NotFound(); 4767 lookup_.NotFound();
4765 return false; 4768 return false;
4766 } 4769 }
4767 map->LookupDescriptor(*holder_, *name_, &lookup_); 4770 map->LookupDescriptor(*holder_, *name_, &lookup_);
4768 if (lookup_.IsFound()) return LoadResult(map); 4771 if (lookup_.IsFound()) return LoadResult(map);
4769 } 4772 }
4770 lookup_.NotFound(); 4773 lookup_.NotFound();
4771 return true; 4774 return true;
(...skipping 5044 matching lines...) Expand 10 before | Expand all | Expand 10 after
9816 if (ShouldProduceTraceOutput()) { 9819 if (ShouldProduceTraceOutput()) {
9817 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9820 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9818 } 9821 }
9819 9822
9820 #ifdef DEBUG 9823 #ifdef DEBUG
9821 graph_->Verify(false); // No full verify. 9824 graph_->Verify(false); // No full verify.
9822 #endif 9825 #endif
9823 } 9826 }
9824 9827
9825 } } // namespace v8::internal 9828 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-305309.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698