Promote SkInterpolator unit test to our tests driver.

Promote SkInterpolator unit test to our tests driver.

BUG=None
TEST=make tests && out/Debug/tests -m Interpolator
R=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/11a005ee01973da543fee66f9b14d20a7c407611

[tfarina, 2014-06-25 20:02:55]

https://codereview.chromium.org/351713005/diff/1/tests/InterpolatorTest.cpp
File tests/InterpolatorTest.cpp (right):

https://codereview.chromium.org/351713005/diff/1/tests/InterpolatorTest.cpp#n...
tests/InterpolatorTest.cpp:23: //SkScalar        vv[3];
this is commented out, because the test I commented below.

https://codereview.chromium.org/351713005/diff/1/tests/InterpolatorTest.cpp#n...
tests/InterpolatorTest.cpp:51: //REPORTER_ASSERT(reporter, memcmp(v, iset(vv,
60, 120, 180), sizeof(v)) == 0);
This tests fails:

FAILED: ../../tests/InterpolatorTest.cpp:51	memcmp(v, iset(vv, 60, 120, 180),
sizeof(v)) == 0

[mtklein, 2014-06-25 20:12:39]

lgtm

https://codereview.chromium.org/351713005/diff/20001/tests/InterpolatorTest.cpp
File tests/InterpolatorTest.cpp (right):

https://codereview.chromium.org/351713005/diff/20001/tests/InterpolatorTest.c...
tests/InterpolatorTest.cpp:50: //REPORTER_ASSERT(reporter, memcmp(v, iset(vv,
60, 120, 180), sizeof(v)) == 0);
Interesting.

Maybe move this all down together with a note?

// Found failing when we re-enabled this test:
#if 0
SkScalar vv[3];
REPORTER_ASSERT(...);
#endif

[tfarina, 2014-06-25 20:20:04]

https://codereview.chromium.org/351713005/diff/20001/tests/InterpolatorTest.cpp
File tests/InterpolatorTest.cpp (right):

https://codereview.chromium.org/351713005/diff/20001/tests/InterpolatorTest.c...
tests/InterpolatorTest.cpp:50: //REPORTER_ASSERT(reporter, memcmp(v, iset(vv,
60, 120, 180), sizeof(v)) == 0);
On 2014/06/25 20:12:39, mtklein wrote:
> Interesting.
> 
> Maybe move this all down together with a note?
> 
> // Found failing when we re-enabled this test:
> #if 0
> SkScalar vv[3];
> REPORTER_ASSERT(...);
> #endif

Done.

[mtklein, 2014-06-25 20:28:35]

On 2014/06/25 20:20:04, tfarina wrote:
>
https://codereview.chromium.org/351713005/diff/20001/tests/InterpolatorTest.cpp
> File tests/InterpolatorTest.cpp (right):
> 
>
https://codereview.chromium.org/351713005/diff/20001/tests/InterpolatorTest.c...
> tests/InterpolatorTest.cpp:50: //REPORTER_ASSERT(reporter, memcmp(v, iset(vv,
> 60, 120, 180), sizeof(v)) == 0);
> On 2014/06/25 20:12:39, mtklein wrote:
> > Interesting.
> > 
> > Maybe move this all down together with a note?
> > 
> > // Found failing when we re-enabled this test:
> > #if 0
> > SkScalar vv[3];
> > REPORTER_ASSERT(...);
> > #endif
> 
> Done.

lgtm

[tfarina, 2014-06-26 13:44:04]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-26 13:44:53]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/351713005/40001

[commit-bot: I haz the power, 2014-06-26 13:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 13:44:57]

Presubmit check for 351713005-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com')

[mtklein, 2014-06-26 13:52:38]

+Brian for include/.  No API changes.

[bsalomon, 2014-06-26 14:11:12]

On 2014/06/26 13:52:38, mtklein wrote:
> +Brian for include/.  No API changes.

lgtm

[tfarina, 2014-06-26 19:56:24]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-26 19:56:43]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/351713005/40001

[commit-bot: I haz the power, 2014-06-26 20:07:09]

Change committed as 11a005ee01973da543fee66f9b14d20a7c407611