Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1960)

Unified Diff: runtime/vm/service_test.cc

Issue 351703002: Class view: list all/sample instances on request. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/service.cc ('K') | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_test.cc
===================================================================
--- runtime/vm/service_test.cc (revision 37613)
+++ runtime/vm/service_test.cc (working copy)
@@ -838,7 +838,9 @@
"['limit'], ['3']]", class_b.id());
Service::HandleIsolateMessage(isolate, service_msg);
handler.HandleNextMessage();
- ExpectSubstringF(handler.msg(), "\"type\":\"@Array\"");
+ ExpectSubstringF(handler.msg(), "\"type\":\"InstanceSet\"");
+ ExpectSubstringF(handler.msg(), "\"total_count\":2");
+ ExpectSubstringF(handler.msg(), "\"sample_count\":2");
// TODO(koda): Actually parse the response.
static const intptr_t kInstanceListId = 0;
ExpectSubstringF(handler.msg(), "\"id\":\"objects\\/%" Pd "\",\"length\":2",
@@ -854,7 +856,8 @@
"['limit'], ['1']]", class_b.id());
Service::HandleIsolateMessage(isolate, service_msg);
handler.HandleNextMessage();
- ExpectSubstringF(handler.msg(), "\"length\":1");
+ ExpectSubstringF(handler.msg(), "\"total_count\":2");
+ ExpectSubstringF(handler.msg(), "\"sample_count\":1");
}
« runtime/vm/service.cc ('K') | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698