Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.html

Issue 351703002: Class view: list all/sample instances on request. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/class_view.html
===================================================================
--- runtime/bin/vmservice/client/lib/src/elements/class_view.html (revision 37614)
+++ runtime/bin/vmservice/client/lib/src/elements/class_view.html (working copy)
@@ -134,14 +134,37 @@
</template>
<template if="{{ !cls.hasNoAllocations }}">
- current instances ({{ cls.newSpace.current.instances + cls.oldSpace.current.instances }})
+ instances
<div class="memberItem">
- <div class="memberName">shallow size</div>
+ <div class="memberName">currently allocated</div>
<div class="memberValue">
- {{ cls.newSpace.current.bytes + cls.oldSpace.current.bytes | formatSize }}
+ count {{ cls.newSpace.current.instances + cls.oldSpace.current.instances }}
+ (shallow size {{ cls.newSpace.current.bytes + cls.oldSpace.current.bytes | formatSize }})
</div>
</div>
<div class="memberItem">
+ <div class="memberName">strongly reachable</div>
+ <div class="memberValue">
+ <template if="{{ instances == null }}">
+ <eval-link callback="{{ reachable }}"
+ label="[find]"
+ expr="100">
+ </eval-link>
+ </template>
+ <template if="{{ instances != null }}">
+ sample
+ <instance-ref ref="{{ instances['sample'] }}"></instance-ref>
+ <template if="{{ instances['total_count'] > instances['sample_count'] }}">
+ <eval-link callback="{{ reachable }}"
+ label="[more]"
+ expr="{{ instances['sample_count'] * 2 }}">
+ </eval-link>
+ </template>
+ of total {{ instances['total_count'] }}
+ </template>
+ </div>
+ </div>
+ <div class="memberItem">
<div class="memberName">retained size</div>
<div class="memberValue">
<template if="{{ retainedBytes == null }}">

Powered by Google App Engine
This is Rietveld 408576698