Class view: list all/sample instances on request.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 1120 matching lines @@
     return true;
   }
   ObjectGraph graph(isolate);
   intptr_t retained_size = graph.SizeRetainedByClass(cls.id());
   const Object& result = Object::Handle(Integer::New(retained_size));
   result.PrintJSON(js, true);
   return true;
 }
 
 
-class GetInstancesVisitor : public ObjectVisitor {
+class GetInstancesVisitor : public ObjectGraph::Visitor {
  public:
-  GetInstancesVisitor(Isolate* isolate, const Class& cls, const Array& storage)
-      : ObjectVisitor(isolate), cls_(cls), storage_(storage), count_(0) {}
+  GetInstancesVisitor(const Class& cls, const Array& storage)
+      : cls_(cls), storage_(storage), count_(0) {}
 
-  virtual void VisitObject(RawObject* raw_obj) {
+  virtual Direction VisitObject(ObjectGraph::StackIterator* it) {
+    RawObject* raw_obj = it->Get();
     if (raw_obj->IsFreeListElement()) {
-      return;
+      return kProceed;
     }
-    REUSABLE_OBJECT_HANDLESCOPE(isolate());
-    Object& obj = isolate()->ObjectHandle();
+    Isolate* isolate = Isolate::Current();
+    REUSABLE_OBJECT_HANDLESCOPE(isolate);
+    Object& obj = isolate->ObjectHandle();
     obj = raw_obj;
     if (obj.GetClassId() == cls_.id()) {
       if (!storage_.IsNull() && count_ < storage_.Length()) {
         storage_.SetAt(count_, obj);
       }
       ++count_;
     }
+    return kProceed;
   }
 
   intptr_t count() const { return count_; }
 
  private:
   const Class& cls_;
   const Array& storage_;
   intptr_t count_;
 };
 
 
 static bool HandleClassesInstances(Isolate* isolate, const Class& cls,
                                    JSONStream* js) {
   if (js->num_arguments() != 3) {
     PrintError(js, "Command too long");
     return true;
   }
   intptr_t limit;
   if (!GetIntegerId(js->LookupOption("limit"), &limit)) {
     PrintError(js, "instances expects a 'limit' option\n",
                js->num_arguments());
     return true;
   }
   Array& storage = Array::Handle(Array::New(limit));
-  GetInstancesVisitor visitor(isolate, cls, storage);
-  isolate->heap()->IterateObjects(&visitor);
+  GetInstancesVisitor visitor(cls, storage);
+  ObjectGraph graph(isolate);
+  graph.IterateObjects(&visitor);
   intptr_t count = visitor.count();
   if (count < limit) {
     // Truncate the list using utility method for GrowableObjectArray.
     GrowableObjectArray& wrapper = GrowableObjectArray::Handle(
         GrowableObjectArray::New(storage));
     wrapper.SetLength(count);
     storage = Array::MakeArray(wrapper);
   }
-  storage.PrintJSON(js, true);
+  JSONObject jsobj(js);
+  jsobj.AddProperty("type", "InstanceSet");
+  jsobj.AddProperty("id", "instance_set");
+  jsobj.AddProperty("totalCount", count);
+  jsobj.AddProperty("sampleCount", storage.Length());
+  jsobj.AddProperty("sample", storage);
   return true;
 }
 
 
 static bool HandleClasses(Isolate* isolate, JSONStream* js) {
   if (js->num_arguments() == 1) {
     ClassTable* table = isolate->class_table();
     JSONObject jsobj(js);
     table->PrintToJSONObject(&jsobj);
     return true;
@@ skipping 969 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart