Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 351683009: Remove remaining dependencies on allocation.h from a few platform files (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove remaining dependencies on allocation.h from a few platform files I could move parts of allocation to base/ instead, but I see little to no value in the allocation base classes, soo.. BUG=none R=bmeurer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/time.h View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-06-27 11:10:27 UTC) #1
Benedikt Meurer
LGTM
6 years, 5 months ago (2014-06-27 11:35:43 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-06-27 11:37:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698