Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 351683007: Remove the OS() guard from ThreadIdentifierDataPthreads.cpp (Closed)

Created:
6 years, 5 months ago by lgombos
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

In general the project should avoid using OS() guards when possible. In this particular case both OS() and PTHREAD_KEYS_MAX are used as a guard, even though using PTHREAD_KEYS_MAX as a guard is sufficient. Not only that this solution works not just for ANDROID but also for other systems where chromium might be ported to (in or out of the tree). As an example the proposed change would work on HURD systems as well (the support for HURD is not maintained in the tree, but it demonstrates that the change handles those systems as well). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/wtf/ThreadIdentifierDataPthreads.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
PTAL - simple cleanup with a stated goal.
6 years, 5 months ago (2014-06-27 15:38:59 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-06-27 16:50:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/351683007/1
6 years, 5 months ago (2014-06-27 16:50:29 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 16:53:16 UTC) #4
Message was sent while issue was closed.
Change committed as 177115

Powered by Google App Engine
This is Rietveld 408576698