content/browser/renderer_host/render_widget_host_view_base.h - Issue 351683002: Adds link disambiguation popup support to Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: attempt to fix athena build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index ad81506b72fa5a595954417d099892a58c2a0498..31906dd4d3a5b48a985ecd81303b11c820bf2823 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -335,10 +335,12 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

size_t start_offset,

size_t end_offset) {};

-#if defined(OS_ANDROID)

- virtual void ShowDisambiguationPopup(const gfx::Rect& target_rect,

+#if defined(OS_ANDROID) || defined(TOOLKIT_VIEWS)

+ virtual void ShowDisambiguationPopup(const gfx::Rect& rect_pixels,

const SkBitmap& zoomed_bitmap) = 0;

+#endif

+#if defined(OS_ANDROID)

// Instructs the view to not drop the surface even when the view is hidden.

virtual void LockCompositingSurface() = 0;

virtual void UnlockCompositingSurface() = 0;