content/browser/android/content_view_core_impl.cc - Issue 351683002: Adds link disambiguation popup support to Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: attempt to fix athena build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index c473c093581c6d3fdddb7b18ad3e748c05c4193f..59fcb4041ff30812151ed216c12a577a826316b1 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -654,7 +654,7 @@ void ContentViewCoreImpl::StartContentIntent(const GURL& content_url) {

}

void ContentViewCoreImpl::ShowDisambiguationPopup(

- const gfx::Rect& target_rect,

+ const gfx::Rect& rect_pixels,

const SkBitmap& zoomed_bitmap) {

JNIEnv* env = AttachCurrentThread();

@@ -662,7 +662,7 @@ void ContentViewCoreImpl::ShowDisambiguationPopup(

if (obj.is_null())

return;

- ScopedJavaLocalRef<jobject> rect_object(CreateJavaRect(env, target_rect));

+ ScopedJavaLocalRef<jobject> rect_object(CreateJavaRect(env, rect_pixels));

ScopedJavaLocalRef<jobject> java_bitmap =

gfx::ConvertToJavaBitmap(&zoomed_bitmap);