Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed scrolling cruft Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
diff --git a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
index b7170b3a8fc7dd697e3c650a8ced4f184ed75a9e..610e1ae56d0a738a72234f9d930081e4aa338bd8 100644
--- a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
+++ b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
@@ -11,6 +11,7 @@
#include "components/renderer_context_menu/context_menu_delegate.h"
#include "content/public/browser/web_contents_view_delegate.h"
+class LinkDisambiguationPopup;
class RenderViewContextMenu;
class RenderViewContextMenuViews;
@@ -49,6 +50,15 @@ class ChromeWebContentsViewDelegateViews
content::RenderFrameHost* render_frame_host,
const content::ContextMenuParams& params) OVERRIDE;
virtual void SizeChanged(const gfx::Size& size) OVERRIDE;
+#if defined(OS_WIN)
sky 2014/08/04 20:05:19 I don't think you should have any ifdefs in this h
luken 2014/09/11 01:07:26 Done.
+ virtual void ShowDisambiguationPopup(
+ const gfx::Rect& target_rect,
+ const SkBitmap& zoomed_bitmap,
+ const gfx::NativeView content,
+ const content::WebContentsViewDelegate::GestureCallback& callback)
+ OVERRIDE;
+ virtual void HideDisambiguationPopup() OVERRIDE;
+#endif
// Overridden from ContextMenuDelegate.
virtual scoped_ptr<RenderViewContextMenu> BuildMenu(
@@ -74,6 +84,10 @@ class ChromeWebContentsViewDelegateViews
content::WebContents* web_contents_;
+#if defined(OS_WIN)
+ scoped_ptr<LinkDisambiguationPopup> link_disambiguation_popup_;
+#endif
+
DISALLOW_COPY_AND_ASSIGN(ChromeWebContentsViewDelegateViews);
};

Powered by Google App Engine
This is Rietveld 408576698