Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2345)

Unified Diff: content/public/browser/web_contents_view_delegate.h

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: making interface changes windows-only Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_view_delegate.h
diff --git a/content/public/browser/web_contents_view_delegate.h b/content/public/browser/web_contents_view_delegate.h
index b0e3f6255b90fd9be86762263706cd7b71a78a56..934018098216c313a5da36f944dec2116aee41a2 100644
--- a/content/public/browser/web_contents_view_delegate.h
+++ b/content/public/browser/web_contents_view_delegate.h
@@ -9,7 +9,9 @@
#import <Cocoa/Cocoa.h>
#endif
+#include "base/callback_forward.h"
#include "content/common/content_export.h"
+#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/native_widget_types.h"
#if defined(OS_MACOSX)
@@ -22,6 +24,7 @@ class Size;
namespace ui {
class FocusStoreGtk;
+class GestureEvent;
}
namespace content {
@@ -43,6 +46,21 @@ class CONTENT_EXPORT WebContentsViewDelegate {
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) = 0;
+#if defined(OS_WIN)
+ // Shows a popup window containing the |zoomed_bitmap| of web content with
+ // more than one link, allowing the user to more easily select which link
+ // they were trying to touch. |target_rect| is the rectangle in DIPs in the
+ // coordinate system of |content| that has been scaled up in |zoomed_bitmap|.
+ // Should the popup receive any gesture events they should be translated back
+ // to the coordinate system of |content| and then provided to the |callback|
+ // for forwarding on to the original scale web content.
+ typedef base::Callback<void(ui::GestureEvent* event)> GestureCallback;
+ virtual void ShowLinkDisambiguationPopup(const gfx::Rect& target_rect,
+ const SkBitmap& zoomed_bitmap,
+ const gfx::NativeView content,
+ const GestureCallback callback) = 0;
jam 2014/07/30 20:29:03 const reference
luken 2014/07/31 01:41:47 Done.
+#endif
+
#if defined(USE_AURA)
// These methods allow the embedder to intercept WebContentsViewWin's
// implementation of these WebContentsView methods. See the WebContentsView

Powered by Google App Engine
This is Rietveld 408576698