Adds link disambiguation popup support to Windows.

chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h

Index: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
diff --git a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
index b7170b3a8fc7dd697e3c650a8ced4f184ed75a9e..e213769680fb356cb3e1e1f44156292373d94493 100644
--- a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
+++ b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h
@@ -11,6 +11,7 @@
 #include "components/renderer_context_menu/context_menu_delegate.h"
 #include "content/public/browser/web_contents_view_delegate.h"
 
+class LinkDisambiguationPopup;
 class RenderViewContextMenu;
 class RenderViewContextMenuViews;
 
@@ -49,6 +50,14 @@ class ChromeWebContentsViewDelegateViews
       content::RenderFrameHost* render_frame_host,
       const content::ContextMenuParams& params) OVERRIDE;
   virtual void SizeChanged(const gfx::Size& size) OVERRIDE;
+#if defined(OS_WIN)

[sky, 2014/07/30 21:50:37]

Why is this windows specific?

[luken, 2014/07/31 01:41:47]

I had to make the function windows-specific in WebContentsViewDelegate, as there
are several implementations of that interface (for example in Android:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/na...)
that I didn't want to have to clutter up the CL with empty definitions of.

[sky, 2014/07/31 15:37:40]

That's not a good reason for all the ifdefs. If you want to minimize the scope
land the cl that the function and all the overrides first.

[luken, 2014/07/31 23:57:42]

OK, I'll start a CL that just lands the function and the overrides first. Just
to be clear, is this the only function addition you object to being behind #if
defined(OS_WIN)? Or are there others?
Thanks

+  virtual void ShowLinkDisambiguationPopup(
+      const gfx::Rect& target_rect,
+      const SkBitmap& zoomed_bitmap,
+      const gfx::NativeView content,
+      const content::WebContentsViewDelegate::GestureCallback callback)
+      OVERRIDE;
+#endif
 
   // Overridden from ContextMenuDelegate.
   virtual scoped_ptr<RenderViewContextMenu> BuildMenu(
@@ -74,6 +83,10 @@ class ChromeWebContentsViewDelegateViews
 
   content::WebContents* web_contents_;
 
+#if defined(OS_WIN)
+  scoped_ptr<LinkDisambiguationPopup> link_disambiguation_popup_;
+#endif
+
   DISALLOW_COPY_AND_ASSIGN(ChromeWebContentsViewDelegateViews);
 };