ui/keyboard/keyboard_controller.cc - Issue 351683002: Adds link disambiguation popup support to Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: responding to cpu's feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/keyboard/keyboard_controller.cc

diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc

index f74ff7a612e1b63b927472462f1de31f6665b55f..1dab5a942cd9cfba3c687f74cb84fb442146645f 100644

--- a/ui/keyboard/keyboard_controller.cc

+++ b/ui/keyboard/keyboard_controller.cc

@@ -118,6 +118,8 @@ class KeyboardWindowDelegate : public aura::WindowDelegate {

keyboard::DefaultKeyboardBoundsFromWindowBounds(bounds_);

mask->addRect(RectToSkRect(keyboard_bounds));

}

+ virtual void OnLinkDisambiguationPopupRequested(

+ const gfx::Rect& target_rect, const SkBitmap& zoomed_bitmap) OVERRIDE {}

gfx::Rect bounds_;

keyboard::KeyboardControllerProxy* proxy_;