Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: first patch ready for review Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_controller.cc
diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc
index f74ff7a612e1b63b927472462f1de31f6665b55f..1dab5a942cd9cfba3c687f74cb84fb442146645f 100644
--- a/ui/keyboard/keyboard_controller.cc
+++ b/ui/keyboard/keyboard_controller.cc
@@ -118,6 +118,8 @@ class KeyboardWindowDelegate : public aura::WindowDelegate {
keyboard::DefaultKeyboardBoundsFromWindowBounds(bounds_);
mask->addRect(RectToSkRect(keyboard_bounds));
}
+ virtual void OnLinkDisambiguationPopupRequested(
+ const gfx::Rect& target_rect, const SkBitmap& zoomed_bitmap) OVERRIDE {}
cpu_(ooo_6.6-7.5) 2014/07/20 01:54:06 what happens if the user starts typing, should we
luken 2014/07/21 18:01:29 The LDP eats keystrokes, but will close if the use
gfx::Rect bounds_;
keyboard::KeyboardControllerProxy* proxy_;

Powered by Google App Engine
This is Rietveld 408576698