content/browser/renderer_host/render_widget_host_impl.cc - Issue 351683002: Adds link disambiguation popup support to Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: first patch ready for review Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index 8ca48bc231fa6c421265c9822173a90db1ea9570..86c69a3a99eb1b296b24759a77b9467f1a5d14d2 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -1637,7 +1637,7 @@ void RenderWidgetHostImpl::OnShowDisambiguationPopup(

SkBitmap zoomed_bitmap;

zoomed_bitmap.installPixels(info, bitmap->pixels(), info.minRowBytes());

-#if defined(OS_ANDROID)

+#if defined(OS_ANDROID) || defined(OS_WIN)

if (view_)

view_->ShowDisambiguationPopup(rect, zoomed_bitmap);

#else

cpu_(ooo_6.6-7.5) 2014/07/20 01:50:44 add comment about the rect coordinates, for future

luken 2014/07/21 18:01:29 Done.