Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: runtime/lib/array.dart

Issue 351673002: Add class id constants fields to dart:_internal class 'ClassID'. Use the fields in the library (mor… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/double_patch.dart » ('j') | runtime/vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/array.dart
===================================================================
--- runtime/lib/array.dart (revision 37613)
+++ runtime/lib/array.dart (working copy)
@@ -5,7 +5,6 @@
// TODO(srdjan): Use shared array implementation.
class _List<E> implements List<E> {
- static final int _classId = ClassID.getID(new _List(0));
factory _List(length) native "List_allocate";
@@ -68,7 +67,7 @@
int length = end - start;
if (length == 0) return;
- if (iterable is _List) {
+ if (ClassID.getID(iterable) == ClassID.cidOneByteString) {
_copyFromObjectArray(iterable, skipCount, start, length);
} else {
if (iterable is List) {
@@ -271,7 +270,6 @@
// implementation (checks when modifying). We should keep watching
// the inline cache misses.
class _ImmutableList<E> implements List<E> {
- static final int _classId = ClassID.getID(const []);
factory _ImmutableList._uninstantiable() {
throw new UnsupportedError(
« no previous file with comments | « no previous file | runtime/lib/double_patch.dart » ('j') | runtime/vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698