Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Side by Side Diff: runtime/lib/double_patch.dart

Issue 351673002: Add class id constants fields to dart:_internal class 'ClassID'. Use the fields in the library (mor… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Dart core library. 4 // Dart core library.
5 5
6 // VM implementation of double. 6 // VM implementation of double.
7 7
8 patch class double { 8 patch class double {
9 9
10 static double _native_parse(_OneByteString string) native "Double_parse"; 10 static double _native_parse(_OneByteString string) native "Double_parse";
11 11
12 static double _parse(var str) { 12 static double _parse(var str) {
13 str = str.trim(); 13 str = str.trim();
14 14
15 if (str.length == 0) return null; 15 if (str.length == 0) return null;
16 16
17 final ccid = ClassID.getID(str); 17 final ccid = ClassID.getID(str);
18 _OneByteString oneByteString; 18 _OneByteString oneByteString;
19 // TODO(floitsch): Allow _ExternalOneByteStrings. As of May 2013 they don't 19 // TODO(Srdjan): Allow _ExternalOneByteStrings.
20 // have any _classId. 20 if (ccid == ClassID.cidOneByteString) {
21 if (ccid != _OneByteString._classId) { 21 oneByteString = str;
22 } else {
22 int length = str.length; 23 int length = str.length;
23 var s = _OneByteString._allocate(length); 24 var s = _OneByteString._allocate(length);
24 for (int i = 0; i < length; i++) { 25 for (int i = 0; i < length; i++) {
25 int currentUnit = str.codeUnitAt(i); 26 int currentUnit = str.codeUnitAt(i);
26 // All valid trimmed double strings must be ASCII. 27 // All valid trimmed double strings must be ASCII.
27 if (currentUnit < 128) { 28 if (currentUnit < 128) {
28 s._setAt(i, currentUnit); 29 s._setAt(i, currentUnit);
29 } else { 30 } else {
30 return null; 31 return null;
31 } 32 }
32 } 33 }
33 oneByteString = s; 34 oneByteString = s;
34 } else {
35 oneByteString = str;
36 } 35 }
37 36
38 return _native_parse(oneByteString); 37 return _native_parse(oneByteString);
39 } 38 }
40 39
41 /* patch */ static double parse(String str, 40 /* patch */ static double parse(String str,
42 [double onError(String str)]) { 41 [double onError(String str)]) {
43 var result = _parse(str); 42 var result = _parse(str);
44 if (result == null) { 43 if (result == null) {
45 if (onError == null) throw new FormatException(str); 44 if (onError == null) throw new FormatException(str);
46 return onError(str); 45 return onError(str);
47 } 46 }
48 return result; 47 return result;
49 } 48 }
50 } 49 }
OLDNEW
« no previous file with comments | « runtime/lib/array.dart ('k') | runtime/lib/growable_array.dart » ('j') | runtime/vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698