Add class id constants fields to dart:_internal class 'ClassID'. Use the fields in the library (mor…

runtime/lib/array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 // TODO(srdjan): Use shared array implementation.
 class _List<E> implements List<E> {
-  static final int _classId = ClassID.getID(new _List(0));
 
   factory _List(length) native "List_allocate";
 
   E operator [](int index) native "List_getIndexed";
 
   void operator []=(int index, E value) native "List_setIndexed";
 
   String toString() {
     return ListBase.listToString(this);
   }
@@ skipping 42 matching lines @@
   void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
     if (start < 0 || start > this.length) {
       throw new RangeError.range(start, 0, this.length);
     }
     if (end < start || end > this.length) {
       throw new RangeError.range(end, start, this.length);
     }
     int length = end - start;
     if (length == 0) return;
 
-    if (iterable is _List) {
+    if (ClassID.getID(iterable) == ClassID.cidOneByteString) {
       _copyFromObjectArray(iterable, skipCount, start, length);
     } else {
       if (iterable is List) {
         Lists.copy(iterable, skipCount, this, start, length);
       } else {
         Iterator it = iterable.iterator;
         while (skipCount > 0) {
           if (!it.moveNext()) return;
           skipCount--;
         }
@@ skipping 182 matching lines @@
 
 
 // This is essentially the same class as _List, but it does not
 // permit any modification of array elements from Dart code. We use
 // this class for arrays constructed from Dart array literals.
 // TODO(hausner): We should consider the trade-offs between two
 // classes (and inline cache misses) versus a field in the native
 // implementation (checks when modifying). We should keep watching
 // the inline cache misses.
 class _ImmutableList<E> implements List<E> {
-  static final int _classId = ClassID.getID(const []);
 
   factory _ImmutableList._uninstantiable() {
     throw new UnsupportedError(
         "ImmutableArray can only be allocated by the VM");
   }
 
   factory _ImmutableList._from(List from, int offset, int length)
       native "ImmutableList_from";
 
   E operator [](int index) native "List_getIndexed";
@@ skipping 245 matching lines @@
     }
     _position = _length;
     _current = null;
     return false;
   }
 
   E get current {
     return _current;
   }
 }