Add class id constants fields to dart:_internal class 'ClassID'. Use the fields in the library (mor…

runtime/lib/growable_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _GrowableList<T> implements List<T> {
-  static final int _classId = ClassID.getID(new _GrowableList(0));
 
   void insert(int index, T element) {
-    if (index < 0 || index > length) {
+    if ((index < 0) || (index > length)) {
       throw new RangeError.range(index, 0, length);
     }
     if (index == this.length) {
       add(element);
       return;
     }
     int oldLength = this.length;
     // We are modifying the length just below the is-check. Without the check
     // Array.copy could throw an exception, leaving the list in a bad state
     // (with a length that has been increased, but without a new element).
-    if (index is! int) throw new ArgumentError(index);
+    if (ClassID.getID(index) != ClassID.cidSmi) throw new ArgumentError(index);

[siva, 2014/06/23 21:23:31]

The previous code was checking for int but now we check only for smi they don't
seem equivalent, are you assuming that index could only be Smi? Do we have
assertion for that elsewhere?

[srdjan, 2014/06/23 22:27:35]

Any index that is not Smi throws an exception, either because it is not an int
or because it is not a Smi (out of range). However, with this change I change
the behavior as instead of RangeError I would throw ArgumentError. Reverting it.

     this.length++;
     Lists.copy(this, index, this, index + 1, oldLength - index);
     this[index] = element;
   }
 
   T removeAt(int index) {
     var result = this[index];
     int newLength = this.length - 1;
     Lists.copy(this, index + 1, this, index, newLength - index);
     this.length = newLength;
@@ skipping 72 matching lines @@
     Lists.indicesCheck(this, start, end);
     if (end == null) end = this.length;
     int length = end - start;
     if (start == end) return <T>[];
     List list = new _GrowableList<T>.withCapacity(length);
     list.length = length;
     Lists.copy(this, start, list, 0, length);
     return list;
   }
 
-  static final int _kDefaultCapacity = 2;
+  static const int _kDefaultCapacity = 2;
 
   factory _GrowableList(int length) {
     var data = new _List((length == 0) ? _kDefaultCapacity : length);
     var result = new _GrowableList<T>.withData(data);
     if (length > 0) {
       result._setLength(length);
     }
     return result;
   }
 
@@ skipping 216 matching lines @@
   }
 
   Set<T> toSet() {
     return new Set<T>.from(this);
   }
 
   Map<int, T> asMap() {
     return IterableMixinWorkaround.asMapList(this);
   }
 }