Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 351633002: DevTools: Implemented new properties of ScreencastFrameMetadata (Closed)

Created:
6 years, 6 months ago by vkuzkokov
Modified:
6 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Implemented new properties of ScreencastFrameMetadata Depends on https://codereview.chromium.org/351003003/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280318

Patch Set 1 #

Patch Set 2 : Rebased. Added property device. Removed bad use of GetRequestedRendererSize #

Total comments: 5

Patch Set 3 : Moved fix to separate patch #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/browser/devtools/renderer_overrides_handler.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vkuzkokov
6 years, 6 months ago (2014-06-23 16:55:29 UTC) #1
vkuzkokov
6 years, 6 months ago (2014-06-25 11:59:46 UTC) #2
pfeldman
https://codereview.chromium.org/351633002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/351633002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc#newcode206 content/browser/devtools/renderer_overrides_handler.cc:206: // FIXME: do not use previous frame metadata. // ...
6 years, 6 months ago (2014-06-25 13:19:10 UTC) #3
dgozman
https://codereview.chromium.org/351633002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/351633002/diff/20001/content/browser/devtools/renderer_overrides_handler.cc#newcode210 content/browser/devtools/renderer_overrides_handler.cc:210: gfx::SizeF view_size_dip = gfx::ScaleSize(metadata.viewport_size, page_scale); I'd say this is ...
6 years, 6 months ago (2014-06-25 13:25:38 UTC) #4
dgozman
lgtm
6 years, 6 months ago (2014-06-26 11:38:08 UTC) #5
pfeldman
lgtm
6 years, 6 months ago (2014-06-26 12:27:36 UTC) #6
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 5 months ago (2014-06-27 11:13:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/351633002/60001
6 years, 5 months ago (2014-06-27 11:14:04 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-06-27 13:04:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 13:07:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/165640)
6 years, 5 months ago (2014-06-27 13:07:18 UTC) #11
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 5 months ago (2014-06-27 13:12:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/351633002/60001
6 years, 5 months ago (2014-06-27 13:13:29 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 13:27:57 UTC) #14
Message was sent while issue was closed. 
Change committed as 280318

Powered by Google App Engine
This is Rietveld 408576698