Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 351603004: Revert of MacViews: Implement Set/Get*Bounds for NativeWidgetMac (Closed)

Created:
6 years, 6 months ago by tapted
Modified:
6 years, 6 months ago
Reviewers:
Robert Sesek, Andre, sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of MacViews: Implement Set/Get*Bounds for NativeWidgetMac (https://codereview.chromium.org/353643002/) Reason for revert: Breaks on 64-bit mac (doh). NSRect is declared differently, so a forward declare won't work. Original issue's description: > MacViews: Implement Set/Get*Bounds for NativeWidgetMac. > > In toolkit-views, "Bounds" corresponds to the NSWindow frame (including > titlebar and borders). This CL maps that onto NSWindow in > InitNativeWidget, GetWindowBoundsInScreen, GetClientAreaBoundsInScreen, > SetBounds and SetSize, performing the required coordinate system > conversions. > > 5 more views_unittests pass after this: > BubbleDelegateTest.NonClientHitTest > CustomFrameViewTest.{CannotMaximizeHidesButton, DefaultButtonLayout, > LeadingButtonLayout}, ViewTest.ConversionsToFromScreen. > > The CL also adds a cross-platform WidgetTest.GetWindowBoundsInScreen to > ensure the behavior is consistent across platforms, and because there > wasn't really anything to cover just bounds setting (e.g. to verify the > coordinate flipping Cocoa needs to do). > > BUG=378134 > TEST=views_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279975 TBR=rsesek@chromium.org,sky@chromium.org,andresantoso@chromium.org NOTREECHECKS=true NOTRY=true BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -172 lines) Patch
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/mac/coordinate_conversion.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gfx/mac/coordinate_conversion.mm View 1 chunk +0 lines, -37 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 5 chunks +16 lines, -48 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of MacViews: Implement Set/Get*Bounds for NativeWidgetMac
6 years, 6 months ago (2014-06-26 10:23:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/351603004/1
6 years, 6 months ago (2014-06-26 10:24:32 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 10:26:03 UTC) #3
Message was sent while issue was closed.
Change committed as 279976

Powered by Google App Engine
This is Rietveld 408576698