DescriptionRevert of MacViews: Implement Set/Get*Bounds for NativeWidgetMac (https://codereview.chromium.org/353643002/)
Reason for revert:
Breaks on 64-bit mac (doh). NSRect is declared differently, so a forward declare won't work.
Original issue's description:
> MacViews: Implement Set/Get*Bounds for NativeWidgetMac.
>
> In toolkit-views, "Bounds" corresponds to the NSWindow frame (including
> titlebar and borders). This CL maps that onto NSWindow in
> InitNativeWidget, GetWindowBoundsInScreen, GetClientAreaBoundsInScreen,
> SetBounds and SetSize, performing the required coordinate system
> conversions.
>
> 5 more views_unittests pass after this:
> BubbleDelegateTest.NonClientHitTest
> CustomFrameViewTest.{CannotMaximizeHidesButton, DefaultButtonLayout,
> LeadingButtonLayout}, ViewTest.ConversionsToFromScreen.
>
> The CL also adds a cross-platform WidgetTest.GetWindowBoundsInScreen to
> ensure the behavior is consistent across platforms, and because there
> wasn't really anything to cover just bounds setting (e.g. to verify the
> coordinate flipping Cocoa needs to do).
>
> BUG=378134
> TEST=views_unittests
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279975
TBR=rsesek@chromium.org,sky@chromium.org,andresantoso@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=378134
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279976
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|