Issue 351603002: [Android] Unit tests for DeviceUtils.

Issue 351603002: [Android] Unit tests for DeviceUtils. (Closed)

Created:
6 years, 6 months ago by jbudorick

Modified:
6 years, 6 months ago

Reviewers:
craigdh, starodub, frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Unit tests for DeviceUtils. BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279294

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+397 lines, -192 lines)			Patch
M	build/android/pylib/android_commands.py	View		5 chunks	+5 lines, -27 lines	0 comments	Download
M	build/android/pylib/device/decorators.py	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	build/android/pylib/device/device_utils.py	View		3 chunks	+12 lines, -4 lines	0 comments	Download
M	build/android/pylib/device/device_utils_test.py	View	1 2	2 chunks	+374 lines, -158 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jbudorick

As promised here: https://codereview.chromium.org/292313015/#msg3

6 years, 6 months ago (2014-06-23 15:27:55 UTC) #1

frankf

lgtm https://codereview.chromium.org/351603002/diff/20001/build/android/pylib/device/device_utils_test.py File build/android/pylib/device/device_utils_test.py (right): https://codereview.chromium.org/351603002/diff/20001/build/android/pylib/device/device_utils_test.py#newcode8 build/android/pylib/device/device_utils_test.py:8: can you file a bug to add pylib ...

6 years, 6 months ago (2014-06-23 21:41:51 UTC) #2

jbudorick

https://codereview.chromium.org/351603002/diff/20001/build/android/pylib/device/device_utils_test.py File build/android/pylib/device/device_utils_test.py (right): https://codereview.chromium.org/351603002/diff/20001/build/android/pylib/device/device_utils_test.py#newcode8 build/android/pylib/device/device_utils_test.py:8: On 2014/06/23 21:41:50, frankf wrote: > can you file ...

6 years, 6 months ago (2014-06-24 00:04:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/351603002/40001

6 years, 6 months ago (2014-06-24 00:06:13 UTC) #5

Message was sent while issue was closed.

Change committed as 279294

Expand Messages | Collapse Messages