src/api.h - Issue 351573002: Make Object::IsFoo const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.h

Issue 351573002: Make Object::IsFoo const. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Feedback. Rebased. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.h

diff --git a/src/api.h b/src/api.h

index 7a688caeee03a5951673d3d1694e78e09e55cf9d..ccede0d2d0ec7ec79d75fa1742dee540c53ada70 100644

--- a/src/api.h

+++ b/src/api.h

@@ -370,8 +370,7 @@ MAKE_TO_LOCAL(ToLocal, DeclaredAccessorDescriptor, DeclaredAccessorDescriptor)

const v8::From* that, bool allow_empty_handle) { \

EXTRA_CHECK(allow_empty_handle || that != NULL); \

EXTRA_CHECK(that == NULL || \

- (*reinterpret_cast<v8::internal::Object**>( \

- const_cast<v8::From*>(that)))->Is##To()); \

+ (*reinterpret_cast<v8::internal::Object* const*>(that))->Is##To()); \

return v8::internal::Handle<v8::internal::To>( \

reinterpret_cast<v8::internal::To**>(const_cast<v8::From*>(that))); \

}

« no previous file with comments | « include/v8.h ('k') | src/objects.h » ('j') | no next file with comments »