Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/objects.cc

Issue 351573002: Make Object::IsFoo const. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Feedback. Rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/allocation-site-scopes.h" 8 #include "src/allocation-site-scopes.h"
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 if (IsBoolean()) return IsTrue(); 85 if (IsBoolean()) return IsTrue();
86 if (IsSmi()) return Smi::cast(this)->value() != 0; 86 if (IsSmi()) return Smi::cast(this)->value() != 0;
87 if (IsUndefined() || IsNull()) return false; 87 if (IsUndefined() || IsNull()) return false;
88 if (IsUndetectableObject()) return false; // Undetectable object is false. 88 if (IsUndetectableObject()) return false; // Undetectable object is false.
89 if (IsString()) return String::cast(this)->length() != 0; 89 if (IsString()) return String::cast(this)->length() != 0;
90 if (IsHeapNumber()) return HeapNumber::cast(this)->HeapNumberBooleanValue(); 90 if (IsHeapNumber()) return HeapNumber::cast(this)->HeapNumberBooleanValue();
91 return true; 91 return true;
92 } 92 }
93 93
94 94
95 bool Object::IsCallable() { 95 bool Object::IsCallable() const {
96 Object* fun = this; 96 const Object* fun = this;
97 while (fun->IsJSFunctionProxy()) { 97 while (fun->IsJSFunctionProxy()) {
98 fun = JSFunctionProxy::cast(fun)->call_trap(); 98 fun = JSFunctionProxy::cast(fun)->call_trap();
99 } 99 }
100 return fun->IsJSFunction() || 100 return fun->IsJSFunction() ||
101 (fun->IsHeapObject() && 101 (fun->IsHeapObject() &&
102 HeapObject::cast(fun)->map()->has_instance_call_handler()); 102 HeapObject::cast(fun)->map()->has_instance_call_handler());
103 } 103 }
104 104
105 105
106 void Object::Lookup(Handle<Name> name, LookupResult* result) { 106 void Object::Lookup(Handle<Name> name, LookupResult* result) {
(...skipping 16883 matching lines...) Expand 10 before | Expand all | Expand 10 after
16990 #define ERROR_MESSAGES_TEXTS(C, T) T, 16990 #define ERROR_MESSAGES_TEXTS(C, T) T,
16991 static const char* error_messages_[] = { 16991 static const char* error_messages_[] = {
16992 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16992 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16993 }; 16993 };
16994 #undef ERROR_MESSAGES_TEXTS 16994 #undef ERROR_MESSAGES_TEXTS
16995 return error_messages_[reason]; 16995 return error_messages_[reason];
16996 } 16996 }
16997 16997
16998 16998
16999 } } // namespace v8::internal 16999 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698