Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 351563002: Add battery_status watchlist in chromium. (Closed)

Created:
6 years, 6 months ago by timvolodine
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add battery_status watchlist in chromium. Add a watchlist for the chromium parts of the Battery Status API. BUG=360068, 122593 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280071

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed Jochen's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M WATCHLISTS View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
timvolodine
6 years, 6 months ago (2014-06-23 11:38:14 UTC) #1
timvolodine
6 years, 6 months ago (2014-06-24 10:09:12 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/351563002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/351563002/diff/1/WATCHLISTS#newcode748 WATCHLISTS:748: 'battery_status': ['timvolodine@chromium.org' ], nit. no space between ' ...
6 years, 6 months ago (2014-06-24 14:04:22 UTC) #3
timvolodine
https://codereview.chromium.org/351563002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/351563002/diff/1/WATCHLISTS#newcode748 WATCHLISTS:748: 'battery_status': ['timvolodine@chromium.org' ], On 2014/06/24 14:04:22, jochen wrote: > ...
6 years, 6 months ago (2014-06-26 14:46:26 UTC) #4
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 6 months ago (2014-06-26 18:00:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/351563002/20001
6 years, 6 months ago (2014-06-26 18:03:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 19:19:58 UTC) #7
Message was sent while issue was closed.
Change committed as 280071

Powered by Google App Engine
This is Rietveld 408576698