chrome/browser/safe_browsing/client_side_detection_host.cc - Issue 351553004: Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.cc

Issue 351553004: Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Linux ASAN tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host.h ('k') | chrome/browser/safe_browsing/client_side_detection_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.cc b/chrome/browser/safe_browsing/client_side_detection_host.cc

index 83e3d542bc2157719eec05c7897e9776ea222c8d..eca7c48592dd3c00dc3ef3c5ad96be08a1d60ed3 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host.cc

@@ -643,7 +643,7 @@ void ClientSideDetectionHost::MaybeShowMalwareWarning(GURL original_url,

void ClientSideDetectionHost::FeatureExtractionDone(

bool success,

- ClientPhishingRequest* request) {

+ scoped_ptr<ClientPhishingRequest> request) {

DCHECK(request);

DVLOG(2) << "Feature extraction done (success:" << success << ") for URL: "

<< request->url() << ". Start sending client phishing request.";

@@ -656,7 +656,7 @@ void ClientSideDetectionHost::FeatureExtractionDone(

}

// Send ping even if the browser feature extraction failed.

csd_service_->SendClientReportPhishingRequest(

- request, // The service takes ownership of the request object.

+ request.release(), // The service takes ownership of the request object.

callback);

}