Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 351523006: Use Consolas for Windows 7 and above as default monospace font (Closed)

Created:
6 years, 6 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 6 months ago
Reviewers:
Bernhard Bauer, scottmg
CC:
chromium-reviews, jshin+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use Consolas for Windows 7 and above as default monospace font Looks better that Courier if Cleartype is enabled and much much better if directwrite is also enabled. TEST=see bug BUG=388087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279449 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279589

Patch Set 1 #

Total comments: 1

Patch Set 2 : check for courier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cpu_(ooo_6.6-7.5)
The change of font has been vetoed by the chrome elders. I am waiting on ...
6 years, 6 months ago (2014-06-24 02:16:48 UTC) #1
Bernhard Bauer
lgtm
6 years, 6 months ago (2014-06-24 07:59:06 UTC) #2
scottmg
lgtm https://codereview.chromium.org/351523006/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.cc File chrome/browser/ui/prefs/prefs_tab_helper.cc (right): https://codereview.chromium.org/351523006/diff/1/chrome/browser/ui/prefs/prefs_tab_helper.cc#newcode132 chrome/browser/ui/prefs/prefs_tab_helper.cc:132: // On Windows with DirectWrite we want to ...
6 years, 6 months ago (2014-06-24 16:40:56 UTC) #3
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 6 months ago (2014-06-24 17:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/351523006/1
6 years, 6 months ago (2014-06-24 17:14:56 UTC) #5
commit-bot: I haz the power
Change committed as 279449
6 years, 6 months ago (2014-06-24 18:27:20 UTC) #6
cpu_(ooo_6.6-7.5)
patch set 2 has a small fix. Turns out that for some locales we have ...
6 years, 6 months ago (2014-06-24 22:29:40 UTC) #7
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 6 months ago (2014-06-24 22:33:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/351523006/20001
6 years, 6 months ago (2014-06-24 22:34:17 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 04:49:00 UTC) #10
Message was sent while issue was closed.
Change committed as 279589

Powered by Google App Engine
This is Rietveld 408576698