Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: sync/sessions/model_type_registry.h

Issue 351523003: sync: Mass rename of non-blocking sync classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/sessions/model_type_registry.h
diff --git a/sync/sessions/model_type_registry.h b/sync/sessions/model_type_registry.h
index 6d05dfc0f3a248f744e5f9f6a02d1a510b15f92d..b4165ded96e76b57eb5ec1df9b64b3831aab6d25 100644
--- a/sync/sessions/model_type_registry.h
+++ b/sync/sessions/model_type_registry.h
@@ -25,8 +25,8 @@ class CommitContributor;
class DirectoryCommitContributor;
class DirectoryUpdateHandler;
class DirectoryTypeDebugInfoEmitter;
-class NonBlockingTypeProcessorCore;
-class NonBlockingTypeProcessor;
+class ModelTypeSyncWorkerImpl;
+class ModelTypeSyncProxyImpl;
class UpdateHandler;
struct DataTypeState;
@@ -51,20 +51,20 @@ class SYNC_EXPORT_PRIVATE ModelTypeRegistry {
// Sets the set of enabled types.
void SetEnabledDirectoryTypes(const ModelSafeRoutingInfo& routing_info);
- // Enables an off-thread type for syncing. Connects the given processor
- // and its task_runner to the newly created processor core.
+ // Enables an off-thread type for syncing. Connects the given proxy
+ // and its task_runner to the newly created worker.
//
- // Expects that the processor's ModelType is not currently enabled.
+ // Expects that the proxy's ModelType is not currently enabled.
void InitializeNonBlockingType(
syncer::ModelType type,
const DataTypeState& data_type_state,
scoped_refptr<base::SequencedTaskRunner> type_task_runner,
- base::WeakPtr<NonBlockingTypeProcessor> processor);
+ base::WeakPtr<ModelTypeSyncProxyImpl> proxy);
Nicolas Zea 2014/06/24 22:42:48 const ref for both
rlarocque 2014/06/24 23:08:33 Done.
// Disables the syncing of an off-thread type.
//
// Expects that the type is currently enabled.
- // Deletes the processor core associated with the type.
+ // Deletes the worker associated with the type.
void RemoveNonBlockingType(syncer::ModelType type);
// Gets the set of enabled types.
@@ -93,7 +93,7 @@ class SYNC_EXPORT_PRIVATE ModelTypeRegistry {
ScopedVector<DirectoryTypeDebugInfoEmitter>
directory_type_debug_info_emitters_;
- ScopedVector<NonBlockingTypeProcessorCore> non_blocking_type_processor_cores_;
+ ScopedVector<ModelTypeSyncWorkerImpl> model_type_sync_workers_;
// Maps of UpdateHandlers and CommitContributors.
// They do not own any of the objects they point to.

Powered by Google App Engine
This is Rietveld 408576698