Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 351483003: Removing Dummy Test Suit - webkit_compositor_bindings_unittests (Closed)

Created:
6 years, 6 months ago by amogh.bihani
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, bulach+watch_chromium.org, cc-bugs_chromium.org, klundberg+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing Dummy Test Suit - webkit_compositor_bindings_unittests A dummy test suit was left behind while moving files from webkit/renderer to content/renderer. Now that all the bots have been disabled to build that test suit, the dummy files can be removed. BUG=265753 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280311

Patch Set 1 #

Patch Set 2 : Adding chromium_trybot.json and chrmoium.fyi.json #

Patch Set 3 : Removing un-invited .gitmodules from PS#2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -132 lines) Patch
M build/all.gyp View 1 6 chunks +0 lines, -6 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 4 chunks +0 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +0 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +4 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +5 lines, -10 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 1 chunk +0 lines, -1 line 0 comments Download
D webkit/renderer/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D webkit/renderer/compositor_bindings/compositor_bindings_dummy_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp View 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/renderer/compositor_bindings/test/run_all_unittests.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
amogh.bihani
PTAL. (It's pre-requisite CL is still under review though.)
6 years, 6 months ago (2014-06-23 05:20:05 UTC) #1
jam
i'm not an owner in these directories, so deferring to others
6 years, 6 months ago (2014-06-23 19:46:30 UTC) #2
jamesr
webkit/ lgtm
6 years, 6 months ago (2014-06-23 19:49:15 UTC) #3
amogh.bihani
pawel/sky@ PTAL.
6 years, 6 months ago (2014-06-24 13:29:00 UTC) #4
amogh.bihani
On 2014/06/24 13:29:00, amogh.bihani wrote: > pawel/sky@ PTAL. Ping!
6 years, 6 months ago (2014-06-25 06:03:24 UTC) #5
sky
Looks like this is in other files in testing/buildbot. For example, chromium_trybot.json. Can you remove ...
6 years, 5 months ago (2014-06-25 16:43:36 UTC) #6
amogh.bihani
Thanks for pointing it out :) I have added the files.
6 years, 5 months ago (2014-06-26 05:12:16 UTC) #7
sky
LGTM
6 years, 5 months ago (2014-06-26 17:06:33 UTC) #8
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 5 months ago (2014-06-27 05:23:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/351483003/40001
6 years, 5 months ago (2014-06-27 05:24:13 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-27 09:10:44 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 13:09:51 UTC) #12
Message was sent while issue was closed.
Change committed as 280311

Powered by Google App Engine
This is Rietveld 408576698