Chromium Code Reviews| Index: Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp |
| diff --git a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp |
| index d3600c35c260d3bf8ea0c2c49afa06e69d226f49..ad3b774fceead918768d445164f477bac295df31 100644 |
| --- a/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp |
| +++ b/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp |
| @@ -123,10 +123,10 @@ static void initializedByEventConstructorReadonlyUint8ArrayAttributeAttributeGet |
| { |
| v8::Handle<v8::Object> holder = info.Holder(); |
| TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder); |
| - RefPtr<Uint8Array> result(impl->initializedByEventConstructorReadonlyUint8ArrayAttribute()); |
| - if (result && DOMDataStore::setReturnValueFromWrapper<V8Uint8Array>(info.GetReturnValue(), result.get())) |
| + RefPtr<Uint8Array> v8Value(impl->initializedByEventConstructorReadonlyUint8ArrayAttribute()); |
|
haraken
2014/06/27 09:00:47
This is not a V8 value. Shall we rename this to cp
bashi
2014/06/27 09:13:30
Done.
|
| + if (v8Value && DOMDataStore::setReturnValueFromWrapper<V8Uint8Array>(info.GetReturnValue(), v8Value.get())) |
| return; |
| - v8::Handle<v8::Value> wrapper = toV8(result.get(), holder, info.GetIsolate()); |
| + v8::Handle<v8::Value> wrapper = toV8(v8Value.get(), holder, info.GetIsolate()); |
| if (!wrapper.IsEmpty()) { |
| V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyUint8ArrayAttribute"), wrapper); |
| v8SetReturnValue(info, wrapper); |
| @@ -144,10 +144,10 @@ static void initializedByEventConstructorReadonlyTestInterfaceEmptyAttributeAttr |
| { |
| v8::Handle<v8::Object> holder = info.Holder(); |
| TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder); |
| - RefPtr<TestInterfaceEmpty> result(impl->initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute()); |
| - if (result && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>(info.GetReturnValue(), result.get())) |
| + RefPtr<TestInterfaceEmpty> v8Value(impl->initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute()); |
| + if (v8Value && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>(info.GetReturnValue(), v8Value.get())) |
| return; |
| - v8::Handle<v8::Value> wrapper = toV8(result.get(), holder, info.GetIsolate()); |
| + v8::Handle<v8::Value> wrapper = toV8(v8Value.get(), holder, info.GetIsolate()); |
| if (!wrapper.IsEmpty()) { |
| V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyTestInterfaceEmptyAttribute"), wrapper); |
| v8SetReturnValue(info, wrapper); |
| @@ -180,15 +180,14 @@ static void initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttri |
| v8::Handle<v8::Object> holder = info.Holder(); |
| TestInterfaceEventConstructor* impl = V8TestInterfaceEventConstructor::toNative(holder); |
| bool isNull = false; |
| - RefPtr<TestInterfaceEmpty> v8Value = impl->initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute(isNull); |
| + RefPtr<TestInterfaceEmpty> v8Value(impl->initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute(isNull)); |
| if (isNull) { |
| v8SetReturnValueNull(info); |
| return; |
| } |
| - RefPtr<TestInterfaceEmpty> result(v8Value); |
| - if (result && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>(info.GetReturnValue(), result.get())) |
| + if (v8Value && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>(info.GetReturnValue(), v8Value.get())) |
| return; |
| - v8::Handle<v8::Value> wrapper = toV8(result.get(), holder, info.GetIsolate()); |
| + v8::Handle<v8::Value> wrapper = toV8(v8Value.get(), holder, info.GetIsolate()); |
| if (!wrapper.IsEmpty()) { |
| V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, v8AtomicString(info.GetIsolate(), "initializedByEventConstructorReadonlyNullableTestInterfaceEmptyAttribute"), wrapper); |
| v8SetReturnValue(info, wrapper); |