Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 351363002: Revert of Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker (Closed)

Created:
6 years, 5 months ago by leng
Modified:
6 years, 5 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, markusheintz_, browser-components-watch_chromium.org, haaawk1
Project:
chromium
Visibility:
Public.

Description

Revert of Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker (https://codereview.chromium.org/351553004/) Reason for revert: Failures on Linux ASAN LSan Tests (2): OnPhishingDetectionDoneDisabled OnPhishingDetectionDoneMultiplePings OnPhishingDetectionDoneNotPhishing OnPhishingDetectionDoneShowInterstitia http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4236 Original issue's description: > Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker > > Callback no longer receive a HistoryService::Handle, but instead client > code should use the returned base::CancelableTaskTracker::TaskId to > cancel an individual task. > > Simplify implementation of BrowserFeatureExtractor as all the methods > from HistoryService that are called uses base::CancelableTaskTracker by > removing the mapping from HistoryService::Handle to request and using a > scoped_ptr to deal with the lifetime of the ClientPhishingRequest object. > > BUG=371818 > TBR=jochen > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280110 TBR=blundell@chromium.org,jochen@chromium.org,bryner@chromium.org,noelutz@chromium.org,sdefresne@chromium.org NOTREECHECKS=true NOTRY=true BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -157 lines) Patch
M chrome/browser/download/download_target_determiner.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/history/history_marshaling.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/history/history_service.cc View 2 chunks +6 lines, -22 lines 0 comments Download
M chrome/browser/history/history_types.h View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.h View 6 chunks +33 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 6 chunks +107 lines, -53 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 5 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
leng
Created Revert of Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker
6 years, 5 months ago (2014-06-26 22:27:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/351363002/1
6 years, 5 months ago (2014-06-26 22:31:29 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-06-26 22:33:52 UTC) #3
Message was sent while issue was closed.
Change committed as 280137

Powered by Google App Engine
This is Rietveld 408576698