Chromium Code Reviews
DescriptionRevert of Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker (https://codereview.chromium.org/351553004/)
Reason for revert:
Failures on Linux ASAN LSan Tests (2):
OnPhishingDetectionDoneDisabled
OnPhishingDetectionDoneMultiplePings
OnPhishingDetectionDoneNotPhishing
OnPhishingDetectionDoneShowInterstitia
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4236
Original issue's description:
> Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker
>
> Callback no longer receive a HistoryService::Handle, but instead client
> code should use the returned base::CancelableTaskTracker::TaskId to
> cancel an individual task.
>
> Simplify implementation of BrowserFeatureExtractor as all the methods
> from HistoryService that are called uses base::CancelableTaskTracker by
> removing the mapping from HistoryService::Handle to request and using a
> scoped_ptr to deal with the lifetime of the ClientPhishingRequest object.
>
> BUG=371818
> TBR=jochen
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280110
TBR=blundell@chromium.org,jochen@chromium.org,bryner@chromium.org,noelutz@chromium.org,sdefresne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371818
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280137
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|