Fix: view-source fails to display < near chunk boundaries

View-source fails to display < in opening tag near chunk boundaries.

If current buffer is terminated with '....<', the token remains in the state Uninitialized and after next ::start call when a new chunk will be received, HTMLSourceTracker cleans previous buffer with '<' symbol. And view-source will contain something like: ... <b></b>b></b> ...

BUG=168581
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177331

[kozyatinskiy1, 2014-06-30 15:57:59]

On 2014/06/30 13:50:23, kozyatinskiy wrote:

@abarth, please take a look. I tried to solve the problem with the patch
attached, but I suppose that there is a better solution.

[abarth-chromium, 2014-06-30 18:05:15]

It's hard for me to evaluate this CL without a test case that shows what
behavior your changing.

[kozyatinskiy1, 2014-06-30 20:35:48]

On 2014/06/30 18:05:15, abarth wrote:
> It's hard for me to evaluate this CL without a test case that shows what
> behavior your changing.

There is one case on issue page:
https://chromium.googlecode.com/issues/attachment?aid=1685810015000&name=wtf2...
And I added another case with incorrect view-source output:
https://code.google.com/p/chromium/issues/detail?id=168581#c22

[abarth-chromium, 2014-06-30 20:39:06]

What I meant is that you should write a test case and include it in your CL.

[kozyatinskiy1, 2014-07-01 11:01:28]

On 2014/06/30 20:39:06, abarth wrote:
> What I meant is that you should write a test case and include it in your CL.

I've added test.

[abarth-chromium, 2014-07-01 14:44:10]

The code change looks good, but the description could use some improvement.

"There is a problem with view-source" isn't a good summary of the issue.  It's a
very general statement.  Perhaps:

"view-source fails to display < near chunk boundaries"

?

I'd then delete the second paragraph.  It doesn't add much information.  The
third paragraph is a good explanation of the issue.  There should be a blank
line between the summary and the paragraph description.

https://codereview.chromium.org/351353005/diff/60001/Source/core/html/parser/...
File Source/core/html/parser/HTMLSourceTracker.cpp (right):

https://codereview.chromium.org/351353005/diff/60001/Source/core/html/parser/...
Source/core/html/parser/HTMLSourceTracker.cpp:34:
HTMLSourceTracker::HTMLSourceTracker() : m_isStarted(false)
The : m_isStarted goes on the next line (indented four spaces)

[kozyatinskiy1, 2014-07-01 16:19:15]

On 2014/07/01 14:44:10, abarth wrote:
> The code change looks good, but the description could use some improvement.
> 
> "There is a problem with view-source" isn't a good summary of the issue.  It's
a
> very general statement.  Perhaps:
> 
> "view-source fails to display < near chunk boundaries"
> 
> ?
> 
> I'd then delete the second paragraph.  It doesn't add much information.  The
> third paragraph is a good explanation of the issue.  There should be a blank
> line between the summary and the paragraph description.
Done.

>
https://codereview.chromium.org/351353005/diff/60001/Source/core/html/parser/...
> File Source/core/html/parser/HTMLSourceTracker.cpp (right):
> 
>
https://codereview.chromium.org/351353005/diff/60001/Source/core/html/parser/...
> Source/core/html/parser/HTMLSourceTracker.cpp:34:
> HTMLSourceTracker::HTMLSourceTracker() : m_isStarted(false)
> The : m_isStarted goes on the next line (indented four spaces)
Done.

[abarth-chromium, 2014-07-01 17:16:16]

lgtm

[commit-bot: I haz the power, 2014-07-01 17:16:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/351353005/80001

[commit-bot: I haz the power, 2014-07-01 20:21:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14901)

[commit-bot: I haz the power, 2014-07-01 20:36:28]

Change committed as 177331