Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 351263002: DevTools: [MQI] text-shadow for label instead of black background color (Closed)

Created:
6 years, 6 months ago by lushnikov
Modified:
6 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [MQI] text-shadow for label instead of black background color This patch uses text shadow for label text instead of black half-opaque background color. BUG=382996 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M Source/devtools/front_end/responsiveDesignView.css View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
See screenshot in the bug. PTAL
6 years, 6 months ago (2014-06-26 13:47:15 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-26 13:52:57 UTC) #2
dgozman
lgtm
6 years, 6 months ago (2014-06-26 13:53:06 UTC) #3
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-26 14:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/351263002/1
6 years, 6 months ago (2014-06-26 14:30:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-26 21:29:23 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 05:47:33 UTC) #7
Message was sent while issue was closed.
Change committed as 177069

Powered by Google App Engine
This is Rietveld 408576698