Source/web/WebViewImpl.cpp - Issue 351213007: Ensure that the controls attribute is correctly reflected in JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 351213007: Ensure that the controls attribute is correctly reflected in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 03a17e4291a42a38a598eb6315447ce66eea4a2f..484a63a76220f755e971438d656d558c3fcbde4f 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3129,7 +3129,7 @@ void WebViewImpl::performMediaPlayerAction(const WebMediaPlayerAction& action,

mediaElement->setLoop(action.enable);

break;

case WebMediaPlayerAction::Controls:

- mediaElement->setControls(action.enable);

+ mediaElement->setBooleanAttribute(HTMLNames::controlsAttr, action.enable);

break;

default:

ASSERT_NOT_REACHED();

« Source/core/html/HTMLMediaElement.h ('K') | « Source/web/ContextMenuClientImpl.cpp ('k') | no next file » | no next file with comments »