Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 351213007: Ensure that the controls attribute is correctly reflected in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 5b2756e307c7194f13580ffbab0eaf47f58488ee..3496f73843de11cea8a2418c76232a16557ed0d2 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -157,9 +157,9 @@ public:
void closeMediaSource();
void durationChanged(double duration, bool requestSeek);
- // controls
philipj_slow 2014/06/27 14:26:19 Leave this as it was, since some effort appears to
- bool controls() const;
- void setControls(bool);
+ // Takes scripting and full screen mode into account.
+ bool shouldShowControls() const;
+
double volume() const;
void setVolume(double, ExceptionState&);
bool muted() const;
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698